Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kando doesn't appear on fullscreen application on mac #522

Open
SeseMueller opened this issue Jul 9, 2024 · 6 comments
Open

Kando doesn't appear on fullscreen application on mac #522

SeseMueller opened this issue Jul 9, 2024 · 6 comments
Labels
bug Something isn't working macOS This affects Kando on macOS

Comments

@SeseMueller
Copy link

Short Summary

In reference to #461 , it seems to break kando working on fullscreen applications. It just jumps to the previous desktop instead.

Steps to Reproduce the Issue

  1. Launch Kando
  2. Open Firefox and fullscreen it
  3. shortcut-open Kando
  4. => it opens on another desktop instead

Kando Version

latest from main branch; 0c0402

Installation Method

Directly from the main branch

Desktop Environment

macOS

Environment Version

Sonoma 14.5

Additional Information

No response

@SeseMueller SeseMueller added the bug Something isn't working label Jul 9, 2024
@Schneegans Schneegans added the macOS This affects Kando on macOS label Jul 10, 2024
@Schneegans
Copy link
Contributor

Hey, thanks for the report! So #517 seems to have introduced some regressions... I can test this once I am home again.

@ognistik do you observe this as well? I cannot test this now but I fear that my macOS 11 behaves differently again 🙄

@ognistik
Copy link
Contributor

ognistik commented Jul 10, 2024

I could not reproduce this. On my end Kando works on fullscreen apps without issues. The only way I can see this behavior is by removing the setVisibleOnAllWorkspaces lines—but then we are back to the previous issue where Kando is just stuck on one space.

@ognistik
Copy link
Contributor

Hi @Schneegans, in reference to this same thing. I was noticing that the setVisibleOnAllWorkspaces lines work great for when the user triggers the shortcut for Kando's menu, but if the user actually wants to see Kando settings, we do not have those lines that bring Kando to the current space (so user is pulled back to whichever space Kando currently is).

Sorry I didn't notice before 🫣. But it can be fixed by moving the setVisibleOnAllWorkspaces block inside the showWindow function, just before the window is actually shown.

I wonder if this is what OP was referring to.

@Schneegans
Copy link
Contributor

@SeseMueller I cannot reproduce this either. On my macOS 11, opening Kando over a fullscreen Firefox just works. Is there anything else which could be of importance? Do you use some window-management tools? Or anything else which could be related?

@ognistik Good catch. Do you want to prepare a PR for this? 😍

@SeseMueller
Copy link
Author

SeseMueller commented Jul 18, 2024

Sorry for the late update.
I was at 0c040 and fast-forwarded to 9df6e (current head) and can sadly only reproduce the issue inconsistently.
The simple setup only triggers the bug sometimes and only on seemingly some applications.
I can't seem to find a pattern on how to trigger the bug.

Open new firefox window and fullscreen it, shortcut kando => no bug
Open obsidian and fullscreen it, shortcut kando => bug
Open new firefox window, fullscreen it, open obsidian, fullscreen it, focus firefox, focus obsidian => no bug
Open new firefox window, fullscreen it, update VSCode and let it auto open in fullscreen, shortcut kando => kando opens on fullscreen firefox instead

I couldn't find any pattern yet. The non-fullscreen usage still works perfectly though.

I don't use any windows-management applications, only vanilla macOS commands and gestures. Though I am using a three-monitor setup, one of which is virtualized; but that should be completely transparent this far away from the metal.

@LucaBoschetto
Copy link
Contributor

I am experiencing the same issue on my system, a Linux Mint with Cinnamon. I will open a separate issue for better tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working macOS This affects Kando on macOS
Projects
None yet
Development

No branches or pull requests

4 participants