hls: add vod_hls_encryption_output_iv directive #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erankor any comment on this pr? |
erankor
reviewed
Mar 15, 2024
ngx_http_vod_hls.c
Outdated
| // https://datatracker.ietf.org/doc/html/rfc8216#section-5.2 | ||
| if (conf->hls.encryption_method == HLS_ENC_AES_128 && | ||
| (conf->hls.m3u8_config.encryption_key_format.len == 0 || ngx_strncmp(conf->hls.m3u8_config.encryption_key_format.data, "identity", conf->hls.m3u8_config.encryption_key_format.len) == 0) && | ||
| conf->hls.output_iv) |
There was a problem hiding this comment.
I don't see why we need all this complexity - would be better to just replace -
encryption_params->return_iv = FALSE;
with -
encryption_params->return_iv = conf->hls.output_iv;
if the user requested an iv - we return an iv.
There was a problem hiding this comment.
Did you mean changing the line 174?
Initially, I only thought about returning the IV received from the external server. However, if you think changing the line 174 is sufficient, I can do that.
|
Note that this is a directive, not a variable, please update the title/description accordingly. |
nonth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue #1507 , add the
vod_hls_encryption_output_ivdirective to outputIVattributes to the#EXT-X-KEYtag in the m3u8 file.This option will apply whenvod_drm_enabledis enabled, andvod_hls_encryption_methodis set toaes-128, withvod_hls_encryption_key_formatset tononeoridentity.