Fix compilation with libavfilter of ffmpeg >= 5.1 #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoelLinn, maybe I'm missing something, but av_channel_layout_from_mask is defined in libavutil, that is probably the reason I initially checked the libavutil version... Why are you checking the libavcodec version? |
|
Mh, the changed structs are in libavcodec though. I guess it doesn’t really matter then; checking any of the two should be fine and I can probably revert that commit. |
New channel API starting with ffmpeg 5.1
JoelLinn
force-pushed
the
fix-libavfilter-ffmpeg51
branch
from
3c7dce4 to
c9daba4
Compare
|
@erankor I removed the commit |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR #1410 apparently did not fix compilation if libavfilter is used. @erankor
However I am not using nginx-vod in an environment that requires filtering so it's hard to test for me, second opinion needed.
@pgassmann fyi