-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aqua tests and fix unbound type parameters #186
Conversation
@devmotion thanks for those tests using Aqua! the reported overwrites seem to be real and we need to find them |
Thesis submitted, so now I have some time to take a look at this! In total there are 28 ambiguities, they can be broken up into a few different categories:
So there are some ambiguities that I have not been able to trigger, I'm probably missing something. They are:
My attempts at triggering these are #1
AcbSeries() * AcbSeries()
AcbSeries() * ArbSeries()
#2
AcbSeries() + AcbSeries()
AcbSeries() + ArbSeries()
#3
AcbSeries()^AcbSeries()
#4
Arb(1 // 2)
Arb(Rational{Int32}(1, 2))
#5
Arf(1 // 2)
Arf(Rational{Int32}(1, 2)) I'm preparing a PR that fixes the easy cases. Then we can see what to do with the rest. |
It would be good to fix these but I thought it would be better to go through them in separate PRs. So I intentionally did not include any fixes in this PR. |
Yes, I guess we can merge this now then! |
The PR adds Aqua tests. On master, both the tests for method ambiguities and for unbound type parameters are broken. I fixed the unbound type parameters in this PR but the method ambiguity issues are not resolved.