Skip to content

[build] several bugs fixed #4044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2020
Merged

[build] several bugs fixed #4044

merged 2 commits into from
Apr 17, 2020

Conversation

alex-ht
Copy link
Contributor

@alex-ht alex-ht commented Apr 17, 2020

Problem 1:

$ cmake -DKALDI_USE_PATCH_NUMBER=ON ../
$ make
Scanning dependencies of target fst
[  0%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/compat.cc.o
[  0%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/flags.cc.o
[  1%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/fst-types.cc.o
[  1%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/fst.cc.o
[  1%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/mapped-file.cc.o
[  2%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/properties.cc.o
[  2%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/symbol-table-ops.cc.o
[  2%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/symbol-table.cc.o
[  3%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/util.cc.o
[  3%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/weight.cc.o
[  3%] Linking CXX static library libfst.a
[  3%] Built target fst
src/base/CMakeFiles/kaldi-base.dir/flags.make:8: *** missing separator.  Stop.
make[1]: *** [CMakeFiles/Makefile2:961: src/base/CMakeFiles/kaldi-base.dir/all] Error 2
make: *** [Makefile:150: all] Error 2

and there is an extra new line

$cat src/base/CMakeFiles/kaldi-base.dir/flags.make
# CMAKE generated file: DO NOT EDIT!
# Generated by "Unix Makefiles" Generator, CMake Version 3.17

# compile CXX with /usr/lib/ccache/c++
CXX_FLAGS =   -std=c++14

CXX_DEFINES = -DHAVE_CLAPACK=1 -DKALDI_NO_PORTAUDIO=1 -DKALDI_VERSION=\"5.5.678
\"

.....

Problem 2: configurations in cmake/third_party/openfst.cmake and CMakeLists.txt are inconsistent.

Problem:
```sh
$ make
Scanning dependencies of target fst
[  0%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/compat.cc.o
[  0%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/flags.cc.o
[  1%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/fst-types.cc.o
[  1%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/fst.cc.o
[  1%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/mapped-file.cc.o
[  2%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/properties.cc.o
[  2%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/symbol-table-ops.cc.o
[  2%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/symbol-table.cc.o
[  3%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/util.cc.o
[  3%] Building CXX object CMakeFiles/fst.dir/openfst/src/lib/weight.cc.o
[  3%] Linking CXX static library libfst.a
[  3%] Built target fst
src/base/CMakeFiles/kaldi-base.dir/flags.make:8: *** missing separator.  Stop.
make[1]: *** [CMakeFiles/Makefile2:961: src/base/CMakeFiles/kaldi-base.dir/all] Error 2
make: *** [Makefile:150: all] Error 2
```
@alex-ht alex-ht changed the title Remove trailing spaces Remove line ending Apr 17, 2020
aligned with cmake/third_party/openfst.cmake:8
@alex-ht alex-ht changed the title Remove line ending [build] several bugs fixed Apr 17, 2020
@danpovey danpovey merged commit 28e2bed into kaldi-asr:master Apr 17, 2020
@alex-ht alex-ht deleted the patch-1 branch April 17, 2020 05:23
pc-seawind pushed a commit to pc-seawind/kaldi that referenced this pull request Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants