From b1586985bbda11218d0de6c166ce28574c418ab4 Mon Sep 17 00:00:00 2001
From: sschmidTU <s.schmid@phonicscore.com>
Date: Tue, 14 May 2024 23:09:08 +0200
Subject: [PATCH] test: fix generateImages script to not read .base64 files etc
 (fix file ending regex) (#676)

only affects visual regression tests basically. (npm run generate:blessed, npm run test:visual:build, etc)
---
 test/Util/generateImages_browserless.mjs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/test/Util/generateImages_browserless.mjs b/test/Util/generateImages_browserless.mjs
index a7f27b4cc..bf53d3c35 100644
--- a/test/Util/generateImages_browserless.mjs
+++ b/test/Util/generateImages_browserless.mjs
@@ -199,6 +199,7 @@ async function init () {
 
     const sampleDirFilenames = FS.readdirSync(sampleDir);
     let samplesToProcess = []; // samples we want to process/generate pngs of, excluding the filtered out files/filenames
+    const fileEndingRegex = "^.*(([.]xml)|([.]musicxml)|([.]mxl))$";
     for (const sampleFilename of sampleDirFilenames) {
         if (osmdTestingMode && filterRegex === "allSmall") {
             if (sampleFilename.match("^(Actor)|(Gounod)")) { // TODO maybe filter by file size instead
@@ -206,8 +207,7 @@ async function init () {
                 continue;
             }
         }
-        // eslint-disable-next-line no-useless-escape
-        if (sampleFilename.match("^.*(\.xml)|(\.musicxml)|(\.mxl)$")) {
+        if (sampleFilename.match(fileEndingRegex)) {
             // debug('found musicxml/mxl: ' + sampleFilename)
             samplesToProcess.push(sampleFilename);
         } else {
@@ -218,7 +218,7 @@ async function init () {
     // filter samples to process by regex if given
     if (filterRegex && filterRegex !== "" && filterRegex !== "all" && !(osmdTestingMode && filterRegex === "allSmall")) {
         debug("filtering samples for regex: " + filterRegex, DEBUG);
-        samplesToProcess = samplesToProcess.filter((filename) => filename.match(filterRegex));
+        samplesToProcess = samplesToProcess.filter((filename) => filename.match(filterRegex) && filename.match(fileEndingRegex));
         debug(`found ${samplesToProcess.length} matches: `, DEBUG);
         for (let i = 0; i < samplesToProcess.length; i++) {
             debug(samplesToProcess[i], DEBUG);