Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermediate state generation between map_resolver & naked_* combinators #18

Closed
JongyCysec opened this issue Sep 29, 2024 · 2 comments
Closed
Assignees
Labels
question Further information is requested

Comments

@JongyCysec
Copy link

          @minseongg 

If you don't mind, can I ask some questions related to hazardflow design?

With respect to "fetch" pipeline stage,
the 2nd & 3rd modules of fetch stage is filter_map and reg_fwd_with_init.

And each of them consists of two submodules again.
For example, "filter_map" is implemented by connecting map_resolver_inner module and naked_fsm_filter_map.
And "reg_fwd_with_init" is implemented by connecting map_resolver_inner and naked_reg_fwd_with_opt_init.

And the distinguishable characteristic is that the resolver type of intermediary interface of such two sub-modules is
Ready<(R,S)>.
However, f : impl Fn(P, S) -> (HOption<EP>, S) argument of map_resolver_inner is |r, _| r in filter_map and reg_fwd_with_init. So, it will not be seen by other modules outside. Furthermore, map_resolver_inner with such f argument does nothing. It just forwards ingress payload to egress payload without changes and it even does not check ready signal of egress resolver.

So I wonder what is the motivation that filter_map or reg_fwd_with_init are divided into two sub-modules where map_resolver_inner seems not necessary.

And I wonder the reason why resolver type of intermediary interface is Ready<(R,S)>.

Thank you.

Originally posted by @JongyCysec in #16 (comment)

@JongyCysec JongyCysec changed the title Functionality of map_resolver & naked_* combinators Intermediate state generation between map_resover_init & naked_ combinators Sep 29, 2024
@minseongg minseongg self-assigned this Sep 30, 2024
@minseongg
Copy link
Member

Answered in #16 (comment)

@minseongg minseongg changed the title Intermediate state generation between map_resover_init & naked_ combinators Intermediate state generation between map_resover & naked_* combinators Sep 30, 2024
@minseongg minseongg changed the title Intermediate state generation between map_resover & naked_* combinators Intermediate state generation between map_resolver & naked_* combinators Sep 30, 2024
@minseongg
Copy link
Member

Closing, feel free to reopen if you have further questions!

@minseongg minseongg added the question Further information is requested label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants