-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move elemental-cli to kairos as a pkg
and archive the repo
#1210
Comments
I do not remember this, but having it separated would be nicer? Wasnt that the point of trying to extract the sdk stuff so we dont:
I think we need to rediscuss this becuase otherwise I dont think its the best way forward. |
Blocked by: #1346 (we first extract the kairos-agent to an new repository and then move elemental-cli code there) |
No longer blocked! |
These are the current elemental-cli commands:
These are the ones I think belong to the kairos-agent lifecycle command:
@Itxaka do you agree? |
@jimmykarily agreed. In fact cloud-init can also be dropped as I don't think it's used anywhere, only the run-stage Alós there is a PR for this already but needs manual QA |
Thanks @Itxaka, I linked the issue with the PR now. Please remember to update issues when you work on them to avoid other people working on the same things. |
Sorry! Was gonna do it tonight but forgot that it's a local holiday and you folks are working 😂 |
libs merged, needs maybe the pull-image command to be exposed, but install/upgrade/reset are hooked to the old agent commands |
Plan:
-We will create a new binary called kairos-register which is the only thing the user should ever have to install on their workstation. It’s the binary that will be used to register a node (e.g. using QR code).
kairos-agent
will become simplykairos
with all the subcommands it currently has plus the functionality that will be moved from elemental-cli. Additionally, it’s going to have a newlifecycle
subcommand which is going to be what elemental-cli used to be (just the low level functionality). Optionally we could have a check, when the user runs thiskairos
binary outside a Kairos OS, it should print a warning and wait for confirmation. The elemental-cli code will be moved to apkg
in thekairos
repository.Acceptance Criteria
kairos
kairos
binary has alifecycle
subommand that does whatelemental-cli
used to doelemental-cli
repo tests are now part of thekairos
repo and they run when they have to run[Optional - maybe move to other issues]
lifecycle
to top levelkairos
commandkairos
binary is executed outside a Kairos OSThe text was updated successfully, but these errors were encountered: