Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Declarative vs imperative keys in the configuration #1016

Open
mauromorales opened this issue Mar 2, 2023 · 0 comments
Open

🐛 Declarative vs imperative keys in the configuration #1016

mauromorales opened this issue Mar 2, 2023 · 0 comments
Labels
bug Something isn't working lane/ux

Comments

@mauromorales
Copy link
Member

I was using the following config and noticed that in some cases we use the declarative voice to define the state of the setup, while in others the imperative one. IMO all keys should be declarative, but the main issue is to have both mixed, because it makes it prone to errors when writing a config.

p2p:
  disable_dht: true #imperative
  auto:
    ha:
      enable: true #imperative
      master_nodes: 2
  network_token: "xxx"
k3s:
  enabled: true #declarative

Kairos version:
1.6.0

@mauromorales mauromorales added bug Something isn't working lane/ux labels Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lane/ux
Projects
Status: No status
Development

No branches or pull requests

1 participant