fix: Remove unnecessary binaries from immucore.files #236
Conversation
We discovered that several binaries are no longer a hard requirement for immucore to work. - Removed 'growpart', 'parted', and 'partprobe' from the immucore.files list and the dracut needed binaries - Streamlined the bundled.go installation check by eliminating redundant binaries - This change reduces the footprint of the immucore package and simplifies the installation process. Signed-off-by: Itxaka <itxaka@kairos.io>
There was a problem hiding this comment.
Pull Request Overview
This PR reduces the footprint of the immucore package by removing unnecessary binary dependencies. The changes eliminate growpart, parted, and partprobe from both the immucore.files list and the dracut installation checks, as these binaries are no longer required for immucore functionality.
Key Changes:
- Removed three partition-related binaries (
growpart,parted,partprobe) from dependency lists - Updated dracut binary checks to reflect the reduced dependency set
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/bundled/bundled.go | Removed partprobe, parted, growpart, and sfdisk from the dracut installation check list |
| pkg/bundled/alpineInit/immucore.files | Removed /usr/bin/growpart, /usr/sbin/parted, and /usr/sbin/partprobe from the required files list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 1 1
Lines 168 168
=======================================
Hits 112 112
Misses 39 39
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Removed "parted", "growpart", and "cloud-utils-growpart" from package lists as they are no longer needed. - This cleanup helps streamline the package management and reduces potential bloat. Signed-off-by: Itxaka <itxaka@kairos.io>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
We discovered that several binaries are no longer a hard requirement for immucore to work.