Report failed tests #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiosilveira
force-pushed
the
chapter22/dealing-with-failure
branch
2 times, most recently
from
e843bb7 to
2848001
Compare
Checklist:
- Invoke tearDown even if the test method fails
- Run multiple tests
- Report failed tests 👈🏼
---
Output:
➜ python3 src/test_case_test.py
Traceback (most recent call last):
File "tdd-xunit-example/src/test_case_test.py", line 24, in <module>
TestCaseTest("testFailedResultFormatting").run()
File "tdd-xunit-example/src/test_case.py", line 17, in run
method()
File "tdd-xunit-example/src/test_case_test.py", line 19, in testFailedResultFormatting
result.testFailed()
^^^^^^^^^^^^^^^^^
AttributeError: 'TestResult' object has no attribute 'testFailed'. Did you mean: 'testStarted'?
Checklist:
- Invoke tearDown even if the test method fails
- Run multiple tests
- Report failed tests 👈🏼
---
Output:
Traceback (most recent call last):
File "tdd-xunit-example/src/test_case_test.py", line 24, in <module>
TestCaseTest("testFailedResultFormatting").run()
File "tdd-xunit-example/src/test_case.py", line 17, in run
method()
File "tdd-xunit-example/src/test_case_test.py", line 20, in testFailedResultFormatting
assert ("1 run, 1 failed" == result.summary())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError
Checklist: - Invoke tearDown even if the test method fails - Run multiple tests - Report failed tests 👈🏼
There's a subtlety hidden in this implementation: if we have any problems during setUp, our test failure will not be correctly reported. A new item was added to the checklist below to cover this case. Checklist: - Invoke tearDown even if the test method fails - Run multiple tests - Report failed tests ✅ - Catch and report setUp errors
Checklist:
- Invoke tearDown even if the test method fails
- Run multiple tests
- Report failed tests ✅
- Catch and report setUp errors 👈🏼
---
Output:
➜ python3 src/test_case_test.py
Traceback (most recent call last):
File "tdd-xunit-example/src/test_case_test.py", line 39, in <module>
TestCaseTestWithBrokenSetup("testFailedSetUp").run()
File "tdd-xunit-example/src/test_case.py", line 15, in run
self.setUp()
File "tdd-xunit-example/src/test_case_test.py", line 11, in setUp
raise Exception
Exception
Checklist: - Invoke tearDown even if the test method fails - Run multiple tests - Report failed tests ✅ - Catch and report setUp errors ✅
kaiosilveira
force-pushed
the
chapter22/dealing-with-failure
branch
from
2848001 to
ca7f326
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chapter 22: Dealing with failure
Our goal in this chapter was to implement a way to capture failed tests and report them, which we managed to accomplish by implementing a new counter for errors in
TestResultand using it atTestCase.Implementation checklist:
✅
InvoketearDownafterward☑️ Invoke
tearDowneven if the test method fails☑️ Run multiple tests
✅
Report collected results✅
Report failed tests✅
Catch and reportsetUperrorsCloses #11