dynamically resolve catalogItem from catalog at Scroll initialization time

Author: kaiosilveira

src/scroll/index.js

@@ -1,9 +1,7 @@
-import { CatalogItem } from '../catalog/item/index.js';
-
 export class Scroll {
-  constructor(id, title, tags, dateLastCleaned) {
+  constructor(id, title, tags, dateLastCleaned, catalogID, catalog) {
     this._id = id;
-    this._catalogItem = new CatalogItem(null, title, tags);
+    this._catalogItem = catalog.get(catalogID);
     this._lastCleaned = dateLastCleaned;
   }
 

src/scroll/index.test.js

@@ -1,21 +1,29 @@
 import { Scroll } from '.';
 import { ManagedDateTime } from '../utils/date-time';
+import { CatalogItem } from '../catalog/item';
+
+const CATALOG_ITEMS = [
+  new CatalogItem(1, 'Regular Scroll', []),
+  new CatalogItem(2, 'Revered Scroll', ['revered']),
+];
+
+const catalog = { get: id => CATALOG_ITEMS.find(item => item.id === id) };
 
 describe('Scroll', () => {
   const lastCleaningDate = new ManagedDateTime('2021-01-01');
 
   it('should have an id', () => {
-    const scroll = new Scroll(1, 'Regular Scroll', []);
+    const scroll = new Scroll(1, 'Regular Scroll', [], lastCleaningDate, 1, catalog);
     expect(scroll.id).toBe(1);
   });
 
   it('should have a title', () => {
-    const scroll = new Scroll(1, 'Regular Scroll', []);
+    const scroll = new Scroll(1, 'Regular Scroll', [], lastCleaningDate, 1, catalog);
     expect(scroll.title).toBe('Regular Scroll');
   });
 
   describe('hasTag', () => {
-    const scroll = new Scroll(1, 'Regular Scroll', ['revered']);
+    const scroll = new Scroll(1, 'Regular Scroll', ['revered'], lastCleaningDate, 2, catalog);
 
     it('should return true if the tag is present', () => {
       expect(scroll.hasTag('revered')).toBe(true);
@@ -28,7 +36,7 @@ describe('Scroll', () => {
 
   describe('daysSinceLastCleaning', () => {
     it('should return the difference in days between last cleaned date and target date', () => {
-      const scroll = new Scroll(1, 'Revered Scroll', ['revered'], lastCleaningDate);
+      const scroll = new Scroll(2, 'Revered Scroll', ['revered'], lastCleaningDate, 2, catalog);
       const targetDate = new ManagedDateTime('2021-01-02');
       expect(scroll.daysSinceLastCleaning(targetDate)).toBe(1);
     });
@@ -38,7 +46,7 @@ describe('Scroll', () => {
     describe('revered scrolls', () => {
       const sixHundredAndNinetyNineDaysLater = new ManagedDateTime('2022-11-31');
       const sevenHundredAndOneDaysLater = new ManagedDateTime('2022-12-03');
-      const scroll = new Scroll(1, 'Revered Scroll', ['revered'], lastCleaningDate);
+      const scroll = new Scroll(2, 'Revered Scroll', ['revered'], lastCleaningDate, 2, catalog);
 
       it('should return true if date last cleaned is greater than 700', () => {
         expect(scroll.needsCleaning(sevenHundredAndOneDaysLater)).toBe(true);
@@ -53,7 +61,7 @@ describe('Scroll', () => {
       const fourteenHundredAndNinetyNineDaysLater = new ManagedDateTime('2025-02-08');
       const fifteenHundredAndOneDaysLater = new ManagedDateTime('2025-02-10');
 
-      const scroll = new Scroll(1, 'Regular Scroll', [], lastCleaningDate);
+      const scroll = new Scroll(1, 'Regular Scroll', [], lastCleaningDate, 1, catalog);
 
       it('should return true if date last cleaned is greater than 1500', () => {
         expect(scroll.needsCleaning(fifteenHundredAndOneDaysLater)).toBe(true);