ex-2: move call to historyLengthFactor to Rating superclass

Author: kaiosilveira

src/using-polymorphism-for-variation/rating/index.js

@@ -30,13 +30,13 @@ export class Rating {
     let result = 2;
     if (this.voyage.zone === 'china') result += 1;
     if (this.voyage.zone === 'east-indies') result += 1;
+    result += this.historyLengthFactor;
     result += this.voyageAndHistoryLengthFactor;
     return result;
   }
 
   get voyageAndHistoryLengthFactor() {
     let result = 0;
-    result += this.historyLengthFactor;
     if (this.voyage.length > 14) result -= 1;
     return result;
   }
@@ -59,7 +59,6 @@ export class ExperiencedChinaRating extends Rating {
   get voyageAndHistoryLengthFactor() {
     let result = 0;
     result += 3;
-    result += this.historyLengthFactor;
     if (this.voyage.length > 12) result += 1;
     if (this.voyage.length > 18) result -= 1;
     return result;

src/using-polymorphism-for-variation/rating/index.test.js

@@ -128,12 +128,6 @@ describe('Rating', () => {
       expect(rating.voyageAndHistoryLengthFactor).toEqual(0);
     });
 
-    it('should add 1 point if history has more than 8 trips', () => {
-      const history = Array.from({ length: 9 }, () => latamVoyage);
-      const rating = new Rating(latamVoyage, history);
-      expect(rating.voyageAndHistoryLengthFactor).toEqual(1);
-    });
-
     it('should remove 1 point if voyage length is greater than 14', () => {
       const voyage = { zone: 'latam', length: 15 };
       const rating = new Rating(voyage, emptyHistory);
@@ -248,12 +242,6 @@ describe('ExperiencedChinaRating', () => {
       expect(rating.voyageAndHistoryLengthFactor).toEqual(3);
     });
 
-    it('should add 1 point if history has more than 10 trips', () => {
-      const history = createHistory({ length: 11, zone: 'china' });
-      const rating = new ExperiencedChinaRating(chinaVoyage, history);
-      expect(rating.voyageAndHistoryLengthFactor).toEqual(4);
-    });
-
     it('should add 1 point if voyage length is greater than 12', () => {
       const longChinaVoyage = { ...chinaVoyage, length: 13 };
       const history = Array.from({ length: 5 }, () => chinaVoyage);