Show file contents from commit or stash #269
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rutherther
force-pushed
the
feat/show-older-file
branch
from
0b8d6af
to
a40c0a1
Compare
Rutherther
force-pushed
the
feat/show-older-file
branch
from
a40c0a1
to
9692dc8
Compare
|
access |
danilonovaisv
approved these changes
Sep 11, 2023
danilonovaisv
approved these changes
Sep 11, 2023
danilonovaisv
approved these changes
Sep 11, 2023
danilonovaisv
approved these changes
Sep 11, 2023
danilonovaisv
approved these changes
Sep 11, 2023
danilonovaisv
approved these changes
Sep 11, 2023
danilonovaisv
approved these changes
Sep 11, 2023
danilonovaisv
approved these changes
Sep 11, 2023
|
approved |
|
What in the spam is happening... I would rather not block you ... @danilonovaisv |
|
Fix the merge conflicts and I'll be happy to merge this 👍 |
|
Hello. I don't think this is in state where it could be merged. It has some issues, such as showing whether the user wants to save the file, and if the user clicks on save, it will get saved to the directory. I am not very skilled with vscode extensions, so I don't really know what's the best way of getting around this. I made this a draft because of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #268, otherwise, there would be an error in arguments to
stashToMagitChanges.Emacs magit allows browsing contents of files from older configs or changes that were stashed. I tried to implement something similar here.
The way it works is that it opens an unsaved file, with
~{commit hash}~before the extension (that is to let vscode recognize language correctly). If the user saves the file, it will be saved right away, without any warnings or anything like that. I think it would be great if that could be changed because it's probably not the intended use case to save the file. The thing is that I am not sure how to achieve that in an effective way.I am open to ideas on improving this.