Keybindings for TAB broken

[ralexstokes]

The keybinding for TAB recently broke for me, I'm assuming due to some underlying change in VSCode (or possibly the Vim extension?).

After a little debugging, I found changing the editor focus scoping fixes the issue:

Change: edit keybinding to use editorTextFocus in lieu of editorFocus.

After the change my keybindings.json looks like:

// other settings elided...
{
    "key": "tab",
    "command": "extension.vim_tab",
    "when": "editorTextFocus && vim.active && !inDebugRepl && vim.mode != 'Insert' && editorLangId != 'magit'"
  },
  {
    "key": "tab",
    "command": "-extension.vim_tab",
    "when": "editorTextFocus && vim.active && !inDebugRepl && vim.mode != 'Insert'"
  },

I'm opening this issue in case anyone else has the problem and is looking for a solution.

[m3dwards]

I had the same. Many thanks!

[lucasnad27]

Just to confirm, another report here. I thought I was going crazy trying to diff an unstaged file with TAB 😂

Thank you for the temp fix @ralexstokes !! Worked like a charm.

[robertfw]

Just ran into this as well. Thanks for the fix!

[alexrenz]

oh my god, you are a life saver! thank you so much ❤️

[davezuch]

Just ran into this too, thanks for the solution!

[nimbletactician]

I am running into this too. Do all of you have vim bindings? I do not have vim bindings.And the above fix does not work for me @ralexstokes

[kahole]

What version of vscode are yall running?

[derkling]

I'm running 1.78.0 and had the same issue.

Fixed by the change proposed by @ralexstokes, thanks!

[m3dwards]

@nimbletactician I'm running vim bindings and have VSpaceCode installed.

[m3dwards]

What version of vscode are yall running?

1.81.1

[nimbletactician]

@kahole Version: 1.82.1

[nimbletactician]

@derkling : Would you happen to have vim bindings too?

[nimbletactician]

Thanks for responding @maxwedwards. I have tried a bunch of settings but still no luck. I do use IntelliJ Keybindings; not sure if that has a bearing.

[ralexstokes]

have VSpaceCode installed.

I'm running this as well, and on 1.82.1 vscode version

[nimbletactician]

Curious about what possible setting needs to be changed for someone like myself running neither of the bindings.

To be precise: The tab folding feature on the Unstaged Changes line is working i.e. when I hit tab on the Unstaged Changes line, it does show/hide the underlying file. However, when I hit the tab on the file line to see the diff, it does not work.

Unstaged changes (3)
modified test/automation/utils.go

@ralexstokes @kahole @maxwedwards

[m3dwards]

I don't know @nimbletactician

I would start by looking at what TAB is currently bound to in your keybindings.

[jlevers]

@nimbletactician I'm running into this issue too. Can't find any obviously overlapping keybindings. I'll update here if I find a solution.

[shapel]

Thank you, @ralexstokes, so much! ❤️

[jordangarrison]

Thank you @ralexstokes, this is great

[kahole]

#287

[kahole]

Separate issue for tab folding problems beyond vim keybindings: #228