feat: use controller name env var: #1078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
yuval-k
approved these changes
Oct 31, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds configurability for the Kagent controller service name by introducing an environment variable KAGENT_CONTROLLER_NAME. Previously, the controller name was hardcoded as "kagent-controller" in the URL construction for agent deployments.
- Adds
GetControllerName()utility function that reads fromKAGENT_CONTROLLER_NAMEenvironment variable - Updates the KAGENT_URL construction in agent deployments to use the new configurable controller name
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go/internal/utils/common.go | Introduces new GetControllerName() function following the same pattern as GetResourceNamespace() |
| go/internal/controller/translator/agent/adk_api_translator.go | Updates KAGENT_URL construction to use the new GetControllerName() function instead of hardcoded "kagent-controller" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
artberger
added a commit
to kagent-dev/website
that referenced
this pull request
Nov 21, 2025
For kagent-dev/kagent#1078 Signed-off-by: Art Berger <art.berger@solo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.