Skip to content

Bugfix: Cannot reuse filter display name #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Haarolean merged 2 commits into from
Apr 26, 2024
Merged

Bugfix: Cannot reuse filter display name #321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
229a2ca
Remove filter bugfix.
Apr 24, 2024
165925e
Merge branch 'main' into kafbat/316
Leshe4ka Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion frontend/src/components/Topics/Topic/Messages/Filters/Filters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { useTopicDetails } from 'lib/hooks/api/topics';
import EditIcon from 'components/common/Icons/EditIcon';
import CloseIcon from 'components/common/Icons/CloseIcon';
import FlexBox from 'components/common/FlexBox/FlexBox';
import { useMessageFiltersStore } from 'lib/hooks/useMessageFiltersStore';

import * as S from './Filters.styled';
import {
Expand Down Expand Up @@ -66,6 +67,7 @@ const Filters: React.FC<FiltersProps> = ({

const { data: topic } = useTopicDetails({ clusterName, topicName });
const [createdEditedSmartId, setCreatedEditedSmartId] = useState<string>();
const remove = useMessageFiltersStore((state) => state.remove);

const partitions = useMemo(() => {
return (topic?.partitions || []).reduce<{
Expand Down Expand Up @@ -209,7 +211,10 @@ const Filters: React.FC<FiltersProps> = ({
<EditIcon />
</S.EditSmartFilterIcon>
<S.DeleteSmartFilterIcon
onClick={() => setSmartFilter(null)}
onClick={() => {
setSmartFilter(null);
remove(smartFilter.id);
}}
disabled={!!createdEditedSmartId}
>
<CloseIcon />
Expand Down