-
-
Notifications
You must be signed in to change notification settings - Fork 223
FE: Fix blocked public assets (#1038) #1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Masqueey! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
|
@Masqueey, thanks for fixing that! I'll also take a look into why these images aren't in the assets directory as they should be. |
@germanosin, while at it, could you please also look at how to run the app with Idea's run configuration with static files built? It's been broken since migrating to gradle. |
|
As German mentioned, these static files should be in assets directory altogether, rather than whitelisting different paths. I'll convert this to a draft while it's being investigated. |
this one fixed. |
|
Agreed! Fixed by #1109. |
What changes did you make?
Added all remaining assets in the
frontend/publicfolder to the list of objects that can be viewed unauthenticated. Fixes #1038.Fixes #1038
Is there anything you'd like reviewers to focus on?
I couldn't figure out how to fix the issue with the logout page, but it is so minor that it can also be ignored. If you have suggestions, let me know and I'll include them in the PR.
How Has This Been Tested?
Why have you not tested your change?
Due to licensing, I can't use docker-desktop but instead use colima. I have tried for the past two hours to get things to work and I can get a build to finish as long as I don't try to build docker images.
I keep getting "Connection refused" when the container tries to connect to localhost. I have ended up on these two seemingly useful comments, but they didn't work for me.
I don't understand Colima or Docker well enough to figure out how to enable the localhost connection. If someone has a way to help me get the environment set up, I'll happily give it a shot and test my own PR.
Otherwise, if you are able to test my PR, please let me know whether it resolved the linked issue. 🙏
Checklist (put an "x" next to all the items, otherwise the build will fail)
A picture of a cute animal (not mandatory but encouraged)
