Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add advantage reminder on concentration from midi-qol #53

Closed
Tallon159 opened this issue Sep 16, 2023 · 5 comments
Closed

Feature: Add advantage reminder on concentration from midi-qol #53

Tallon159 opened this issue Sep 16, 2023 · 5 comments

Comments

@Tallon159
Copy link

Hello,
I noticed that the flag 'flags.midi-qol.advantage.concentration' is not supported by advantage reminder. Is it possible to add it?
Thanks

@kaelad02
Copy link
Owner

I didn't originally support it because that's a flag for Midi's implementation of Concentration checks. The system on its own doesn't have concentration checks and if you're using Midi for that then it's handling that flag already.

What module are you using to handle concentration?

@Tallon159
Copy link
Author

I use Midi to handle concentration but i'm in manual roll. When i use automated roll, the flag is correctly handle by midi but with manual roll, there is no reminder.

@kaelad02
Copy link
Owner

Going over this again, that sounds like a bug with Midi QOL. I took a peek at manual rolls for concentration checks to see if I could add messages to that dialog but it looks like a regular CON saving through. There's nothing passed in the hook I use that reliably identifies it as a concentration check.

I'll check with the other concentration module to see if it does anything like that and see if Midi can do the same.

@kaelad02
Copy link
Owner

I looked into Concentration Notifier and it adds something to the options parameter to indicate that it's a concentration check but... it looks like the system is adding concentration support in version 3.1.0 (foundryvtt/dnd5e#3028). I'm sure there is still a place for concentration in Midi... it frankly might be better if I wait for all this to shakeout before doing this.

@kaelad02
Copy link
Owner

kaelad02 commented Jun 1, 2024

I forgot to close this when I released version 4.0.0. It supports the system's concentration and adds message capabilities w/ flags.adv-reminder.message.ability.concentration.

@kaelad02 kaelad02 closed this as completed Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants