-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving throw advantage flag not working with better rolls for 5e on version 9 #37
Comments
I tested this with the following versions:
I can reproduce the issue and have a workaround for you. Both AR and BR are intercepting the saving throw and ability check calls and the order is different between the two. For an ability check AR runs first and will apply advantage/disadvantage. For a saving throw, BR runs first and sets a flag to fast-forward the roll and so AR skips advantage/disadvantage checks. You can change the order by going into libWrapper's settings and prioritize Advantage Reminder so it shows up first. Open the settings and go to the Module Settings tab. Then scroll down to libWrapper and click the "libWrapper Settings Menu" button. You'll see a bunch of modules in the middle, Unprioritized Packages, section. Select Advantage Reminder and click the Up arrow to move it into the top, Prioritized Packages, section. That will make sure AR runs first and will apply advantage/disadvantage to both ability checks and saving throws. Please confirm that this works for you. |
Awesome, thank you for this! Any chance you know how to fix the +0[Avd w Rage] block not being added for NPCs saving throws? I know it's not your territory anymore, just wanted to see if you knew if I was doing anything wrong. Thank you for your help! |
Glad to hear it worked. As for NPCs not getting that saving throw bonus, I cannot reproduce the problem. I created an effect directly on a Goblin NPC with the |
Was that with the "add" mode, and what priority / value? Thank you again! |
I'm in version 9, and using the better rolls for 5e seems to work great for ability checks, but the saving throw advantage flag doesn't seem to work on saving throws, nor does adding on additional stuff for NPCs, player's saving throws still don't get advantage but their saving throws do display the +0[rage] label I added. Any ideas on how to fix this?
The text was updated successfully, but these errors were encountered: