Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving throw advantage flag not working with better rolls for 5e on version 9 #37

Closed
Hokage3211 opened this issue Oct 5, 2022 · 5 comments

Comments

@Hokage3211
Copy link

I'm in version 9, and using the better rolls for 5e seems to work great for ability checks, but the saving throw advantage flag doesn't seem to work on saving throws, nor does adding on additional stuff for NPCs, player's saving throws still don't get advantage but their saving throws do display the +0[rage] label I added. Any ideas on how to fix this?

image

image

@kaelad02
Copy link
Owner

kaelad02 commented Oct 5, 2022

I tested this with the following versions:

  • Foundry v9.269
  • dnd5e v1.6.3
  • Advantage Reminder v2.0.1
  • Better Rolls v1.7.2

I can reproduce the issue and have a workaround for you. Both AR and BR are intercepting the saving throw and ability check calls and the order is different between the two. For an ability check AR runs first and will apply advantage/disadvantage. For a saving throw, BR runs first and sets a flag to fast-forward the roll and so AR skips advantage/disadvantage checks. You can change the order by going into libWrapper's settings and prioritize Advantage Reminder so it shows up first.

Open the settings and go to the Module Settings tab. Then scroll down to libWrapper and click the "libWrapper Settings Menu" button. You'll see a bunch of modules in the middle, Unprioritized Packages, section. Select Advantage Reminder and click the Up arrow to move it into the top, Prioritized Packages, section. That will make sure AR runs first and will apply advantage/disadvantage to both ability checks and saving throws. Please confirm that this works for you.

image

@Hokage3211
Copy link
Author

Awesome, thank you for this! Any chance you know how to fix the +0[Avd w Rage] block not being added for NPCs saving throws? I know it's not your territory anymore, just wanted to see if you knew if I was doing anything wrong. Thank you for your help!

@kaelad02
Copy link
Owner

kaelad02 commented Oct 5, 2022

Glad to hear it worked. As for NPCs not getting that saving throw bonus, I cannot reproduce the problem. I created an effect directly on a Goblin NPC with the data.abilities.str.bonuses.save key and it worked as expected when I rolled a saving throw. It didn't show up in the character sheet, but when I rolled a STR save I did see it.

@kaelad02 kaelad02 closed this as completed Oct 5, 2022
@Hokage3211
Copy link
Author

Was that with the "add" mode, and what priority / value? Thank you again!

@Hokage3211
Copy link
Author

I found my issue, a module had somehow set the bonus to saving throws on my creature to this
image
which is not good, it has to be set to "+0", or left blank. This menu can be accessed when clicking on the cog wheel when you hover over the strength stat on the 5e stat block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants