Issue with Midi-qol damage rolls

[ChasarooniZ]

When using midi-qol, unable to roll damage, as it gives the following error.

Uncaught (in promise) TypeError: Cannot read properties of null (reading 'shiftKey')
[Detected 4 packages: adv-reminder, lib-wrapper, more-hooks-5e, midi-qol]
    at isFastForwarding (modules/adv-reminder/src/module.js:269)
    at isFastForwardingDamage (modules/adv-reminder/src/module.js:286)
    at Item5e.onRollDamage (modules/adv-reminder/src/module.js:244)
    at Wrapper.🎁call_wrapper [as call_wrapper] (modules/lib-wrapper/lib-wrapper.js:1)
    at Item5e.rollDamagePatch (modules/more-hooks-5e/scripts/item/damageRoll.js:8)
    at Wrapper.🎁call_wrapper [as call_wrapper] (modules/lib-wrapper/lib-wrapper.js:1)
    at Item5e.🎁CONFIG.Item.documentClass.prototype.rollDamage#0 (modules/lib-wrapper/lib-wrapper.js:1)
    at Workflow._next (modules/midi-qol/src/module/workflow.js:472)
    at async Workflow.next (modules/midi-qol/src/module/workflow.js:245)

[kaelad02]

I can't reproduce the issue. I might just put something in anyways, but what version of Foundry and Midi-QOL are you using?

[ChasarooniZ]

• Foundry V. 9.249,
• Midi QOL v 0.9.08

And it seems to apply to actors that don't even have any flags on them?

[ChasarooniZ]

Okay It looks like I can roll damage on it's own. But if I have it setup as follows (I think the auto fast forward damage) is causing all issues.

[ChasarooniZ]

I believe it seems to be related to the midi-qol workflow?

But no I have tested it using SRD items built in to foundry rolling them normally.

[kaelad02]

For some reason midi's passing a null event. I'm taking a look at its code to confirm and see why.

[kaelad02]

It is a regression in midi when you auto-roll damage. If you change midi's settings so it doesn't auto-roll damage it won't happen. I'll file an issue w/ midi but I'll put something in here anyways.

Using version 0.8.85 it does not happen but 0.9.08 it does. For some reason, it's now passing event = null in the roll options to the damage roll where it was missing from roll options before. Passing it as null is causing the problem.

[ChasarooniZ]

Cool, thank you for the response, hopefully it gets resolved.

[kaelad02]

Filed the issue and I'll get a fix for this module now and push that out in the meantime.

https://gitlab.com/tposney/midi-qol/-/issues/686

[kaelad02]

version 1.2 is live with this bug fix

[ChasarooniZ]

ty ty, i see it, hopefully midi qol fixes the compatibility issue