This repository was archived by the owner on Nov 26, 2025. It is now read-only.
Add constant-delay worker #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larskuhtz
reviewed
Dec 13, 2022
main/Main.hs
Outdated
| , _configStratumInterface = "*" | ||
| , _configStratumDifficulty = Stratum.WorkDifficulty | ||
| , _configStratumRate = 1000 | ||
| , _configBlockTime = 30 |
Contributor
There was a problem hiding this comment.
I think, the name could be misleading for users. What about renaming into _configConstantDelayBlockTime, to indicate that it is used (only) by the constant delay worker.
main/Main.hs
Outdated
| <> long "stratum-rate" | ||
| <> help "Rate (in milliseconds) at which a stratum worker thread emits jobs." | ||
| <*< configBlockTime .:: option auto | ||
| % long "block-time" |
Contributor
There was a problem hiding this comment.
rename into constant-delay-block-time?
main/Main.hs
Outdated
| , "stratumInterface" .= _configStratumInterface c | ||
| , "stratumDifficulty" .= _configStratumDifficulty c | ||
| , "stratumRate" .= _configStratumRate c | ||
| , "blockTime" .= _configBlockTime c |
Contributor
There was a problem hiding this comment.
rename into "constantDelayBlockTime"?
Contributor
|
Could you also update the README.md to include the new options? |
edmundnoble
force-pushed
the
edmund/constant-delay-worker
branch
from
69c9a55 to
c94ac08
Compare
edmundnoble
force-pushed
the
edmund/constant-delay-worker
branch
from
c94ac08 to
3265836
Compare
larskuhtz
approved these changes
Dec 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.