-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images imported from airgap tarballs can be deleted by kubelet GC #8781
Comments
yes, the leases that we added a while back only protected the layer content, they did not protect the tags as hoped. We should rework our protections to use the CRI pinned label. |
Thank you for this. This is still very much relevant ! |
Validated on master branch with version v1.29.1-rc1+k3s1Environment DetailsInfrastructure
Node(s) CPU architecture, OS, and Version:
Cluster Configuration:
Config.yaml:
registries.yaml:
Testing Steps
Replication Results:
Before filling up the disc:
Validation Results:
Before filling up the disc:
After:
Additional context / logs:
|
Discussed in #8779
Originally posted by sushiMix November 3, 2023
Hello, I know there are several tickets about it but didn't find a clear view.
Accordingly to this ticket #3193 it seems working from k3s 1.24
but #7569 there is no possible way to protect images.
Accordingly to test It seems still not working.
But I have seen tickets in k8s/containerd :
containerd/containerd#6352 and containerd/containerd#6930
and did a small test:
Use ctr to load an image and add the pinning label
sudo ./ctr images label "my image" io.cri-containerd.pinned=pinned
Fill the disk using
xfs_mkfile
like the first ticketThe image with the pin tag is no more freed when GC is run (like the pause image :)).
I'm using k3s version v1.26.9+k3s1.
Isn't it a solution to protect some images from GC ?
The text was updated successfully, but these errors were encountered: