Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking facebook post menu #20

Closed
levicki opened this issue Jul 21, 2016 · 9 comments
Closed

Breaking facebook post menu #20

levicki opened this issue Jul 21, 2016 · 9 comments

Comments

@levicki
Copy link

levicki commented Jul 21, 2016

According to your support policy you will most certainly ignore this report, but I will still report the issue so that others may lose less time to figure out what is wrong with their Facebook when using this list.

This filter list is breaking facebook post menu (the little down arrow on the top right corner of each post which is used to access options to hide post, unfollow poster, etc):

With ABP JPN list active:
broken

With ABP JPN list inactive:
working

I use this list when visiting Japanese sites so I can definitely live without it, but it would be nice if you loked into it and fixed it.

@k2jp k2jp closed this as completed Jul 22, 2016
@k2jp k2jp reopened this Jul 22, 2016
@item4
Copy link

item4 commented Oct 30, 2016

I also encountered this problem. macOS 10.12.1 + firefox developer edition + ublock origin + ABP JPN

@k2jp
Copy link
Owner

k2jp commented Nov 3, 2016

@toshiya44
Copy link

Try this

! unblocks facebook options menu
@@||www.facebook.com/*/options_menu/?button*$xmlhttprequest,first-party
@@||www.facebook.com/ajax/groups/mall/mall_post_menu.php$xmlhttprequest,first-party

@levicki
Copy link
Author

levicki commented Nov 15, 2016

@k2jp

We all understand your support policy and we respect it, but could you please consider making an exception and including the above provided exclusion filters in your list?

The author of uBlock Origin has been forced to consider removing your list completely from uBlock Origin subscription configuration page since people have started complaining to him about this issue and he is unable to fix it because you are the list owner.

I am sure there are a lot of current and future Japanese uBlock Origin users who would be at a loss if your list was no longer offered on the uBlock Origin subscription configuration page.

@k2jp
Copy link
Owner

k2jp commented Nov 15, 2016

More open-source way

  • @toshiya44 can create/publish complementary subscription for ABP Japanese Filters to fix Facebook problems. Write a blog and share it. This doesn't break Support Policy.

Don't forget EasyList

  • EasyList supports Facebook, right?

Remember the official name

  • ABP Japanese filters (ONLY FOR Japanese and experienced users: READ Support Policy)

Some consideration

  1. Include filters from guest contributors.
  2. The filters will get obsolete sooner or later.
  3. Who to maintain the filters after guest contributors are gone? Who to be responsible for that? New users will continue to create the similar issues again and ask me why filters on Facebook is not updated, repeatedly.

@levicki
Copy link
Author

levicki commented Nov 16, 2016

@k2jp
Thanks for the reply. Allow me to answer your suggestions:

More open-source way
In my opinion collaboration is more open-source than forking.

Don't forget EasyList
Everyone using AdBlock or uBlock Origin is already using EasyList and one (or more) of the regional lists (I use CHN, RUS, JPN). I am not aware of Japanese EasyList, could you be more specific please?

Remember the official name
How do you expect putting a name on something you make available to everyone with Internet access will stop non-Japanese people with interest in Japan culture from using it? If you really do not want outsiders to use your list then you should ask the ad blocking plugin authors not to include it on their list subscription configuration page and block all non-Japanese IPs from downloading the list.

Some considerations
How about just changing the offending line to https:*_ad_$domain=~facebook.com then? That will fix the problem and eliminate the need for you to test or maintain the filter. I see that you already have some domain exclusions in there.

Once again sorry to bother you, if you are certain that you don't want to collaborate we will look into other previously discussed ways of solving the problem.

@k2jp
Copy link
Owner

k2jp commented Nov 17, 2016

A few facts

Based on the Support Policy

  • I don't have to answer questions from uses who do not meet the Support Policy requirement.

@levicki
Your opinion is different from mine and I don't have enough time to answer further questions.
FYI: If you just want to avoid false positives by too generic filters, try the options like genericblock. This option disable filters without domain restriction.
@@||facebook.com^$genericblock

@k2jp
Copy link
Owner

k2jp commented Nov 17, 2016

@toshiya44
FYI:
~third-party has better compatibility compared with first-party.

@levicki
Copy link
Author

levicki commented Nov 17, 2016

@k2jp

One last thing -- I am aware that 日本語 means Japanese Language and when I mentioned "people with interest in Japan culture" I meant "people who are interested in visiting Japanese sites and learning things about Japan and its culture directly from the source (without seeing ads)". Maybe I should have spelled it out the first time around to avoid misunderstanding.

Thank you for your valuable time, and once again sorry for disturbing you.

@levicki levicki closed this as completed Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants