Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cmake to cpp 17 #511

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Update cmake to cpp 17 #511

merged 3 commits into from
Dec 6, 2023

Conversation

ezerhouni
Copy link
Collaborator

I was tried building sherpa from source with torch 2.1 but failed with the following error:

#error C++17 or later compatible compiler is required to use PyTorch

Fixing changing the cpp version in the cmkae file did the trick

@ezerhouni ezerhouni requested a review from csukuangfj December 5, 2023 10:18
csukuangfj
csukuangfj reviewed Dec 5, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@csukuangfj
Copy link
Collaborator

Thank you for your contribution!

@csukuangfj csukuangfj merged commit 03ba173 into k2-fsa:master Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csukuangfj csukuangfj csukuangfj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ezerhouni @csukuangfj