Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(wip) Drop kardianos service #5009

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

(wip) Drop kardianos service #5009

wants to merge 3 commits into from

Conversation

kke
Copy link
Contributor

@kke kke commented Sep 18, 2024

Description

Drops the kardianos/service dependency in favor of local implementation. (currently just abstracts the usages of the dependency behind local pkg/service wrapper)

Fixes #4962

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@kke kke force-pushed the drop-kardianos-service branch 3 times, most recently from c32fad1 to 0cd1033 Compare September 19, 2024 10:22
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop kardianos/service dependency
1 participant