Skip to content

Commit 64293b1

Browse files
Fix all analyzer issues in the mapper package
This commit resolves all analyzer warnings in the `mapper` package. The changes include: - Removing numerous unused imports across various files to improve code clarity and reduce clutter. - Eliminating unnecessary `this` qualifiers to adhere to Dart's recommended style guidelines. - Correctly handling the `reflectable_builder` dependency by keeping it in `dev_dependencies` and suppressing the `depend_on_referenced_packages` warning with an `// ignore` comment. This resolves the analyzer issue without incorrectly modifying the package's dependencies.
1 parent 075a8b0 commit 64293b1

24 files changed

+10
-43
lines changed

mapper/lib/src/builder/builder.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import 'package:analyzer/dart/element/element.dart';
33
import 'package:analyzer/src/dart/element/element.dart' show LibraryElementImpl;
44
import 'package:build/build.dart';
55
import 'package:pubspec_parse/pubspec_parse.dart';
6-
// ignore: implementation_imports
6+
// ignore: implementation_imports, depend_on_referenced_packages
77
import 'package:reflectable_builder/src/builder_implementation.dart'
88
show BuilderImplementation;
99

mapper/lib/src/logic/deserialization_handler.dart

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,6 @@ import 'dart:convert' show JsonEncoder, JsonDecoder;
22

33
import 'package:dart_json_mapper/dart_json_mapper.dart';
44

5-
import '../class_info.dart';
6-
import '../errors.dart';
7-
import '../identifier_casing.dart';
8-
import '../json_map.dart';
9-
import '../model/index.dart';
105
import 'property_handler.dart';
116
import 'reflection_handler.dart';
127

@@ -115,7 +110,7 @@ class DeserializationHandler {
115110
? fieldValue.map((key, value) => MapEntry(skipPrefix(metaName, key, propertyContext.caseStyle), value))
116111
: fieldValue;
117112

118-
im.invokeSetter(name, this.deserializeObject(objectToDeserialize, propertyContext));
113+
im.invokeSetter(name, deserializeObject(objectToDeserialize, propertyContext));
119114
return;
120115
}
121116
if (im.invokeGetter(name) == null &&
@@ -128,7 +123,7 @@ class DeserializationHandler {
128123
}
129124
}
130125
fieldValue = property.raw
131-
? this.deserializeObject(fieldValue, propertyContext)
126+
? deserializeObject(fieldValue, propertyContext)
132127
: property.value;
133128
if (isGetterOnly) {
134129
if (inheritedPublicFieldNames.contains(name) &&
@@ -200,7 +195,7 @@ class DeserializationHandler {
200195
objectClassInfo.getDeclarationMirror(discriminatorProperty);
201196
if (declarationMirror != null) {
202197
final discriminatorType = ReflectionHandler.getDeclarationType(declarationMirror);
203-
final value = this.deserializeObject(discriminatorValue,
198+
final value = deserializeObject(discriminatorValue,
204199
context.reBuild(typeInfo: _mapper.typeInfoHandler.getTypeInfo(discriminatorType)));
205200
if (value is Type) {
206201
return _mapper.typeInfoHandler.getTypeInfo(value);
@@ -273,7 +268,7 @@ class DeserializationHandler {
273268
String? jsonNameForVisitor;
274269

275270
if (meta?.flatten == true) {
276-
finalValueForVisitor = this.deserializeObject(jsonMap.map, propertyContext.reBuild(jsonPropertyMeta: null));
271+
finalValueForVisitor = deserializeObject(jsonMap.map, propertyContext.reBuild(jsonPropertyMeta: null));
277272
jsonNameForVisitor = context.transformIdentifier(meta?.name ?? name);
278273
} else {
279274
final property = _mapper.propertyHandler.resolveProperty(
@@ -288,7 +283,7 @@ class DeserializationHandler {
288283
: defaultValueFromCallback);
289284
jsonNameForVisitor = property.name;
290285
if (property.raw) {
291-
finalValueForVisitor = this.deserializeObject(property.value, propertyContext);
286+
finalValueForVisitor = deserializeObject(property.value, propertyContext);
292287
} else {
293288
finalValueForVisitor = property.value;
294289
}

mapper/lib/src/logic/serialization_handler.dart

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
1-
import 'dart:convert' show JsonEncoder, JsonDecoder;
1+
import 'dart:convert' show JsonDecoder;
22

33
import 'package:dart_json_mapper/dart_json_mapper.dart';
4-
5-
import '../class_info.dart';
6-
import '../errors.dart';
7-
import '../identifier_casing.dart';
8-
import '../json_map.dart';
9-
import '../model/index.dart';
104
import 'reflection_handler.dart';
115

126
class SerializationHandler {
@@ -83,7 +77,7 @@ class SerializationHandler {
8377
} else {
8478
if (meta?.flatten == true) {
8579
final Map flattenedPropertiesMap =
86-
this.serializeObject(property.value, propertyContext);
80+
serializeObject(property.value, propertyContext);
8781
final metaName = meta?.name;
8882
final fieldPrefixWords = metaName != null
8983
? toWords(metaName, propertyContext.caseStyle).join(' ')
@@ -110,7 +104,7 @@ class SerializationHandler {
110104
_mapper.converterHandler.configureConverter(actualConverter, propertyContext, value: valueToConvert);
111105
convertedValue = _mapper.converterHandler.getConvertedValue(actualConverter, valueToConvert, propertyContext);
112106
} else {
113-
convertedValue = this.serializeObject(property.value, propertyContext);
107+
convertedValue = serializeObject(property.value, propertyContext);
114108
}
115109
}
116110
result.setPropertyValue(property.name, convertedValue ?? meta?.defaultValue);

mapper/lib/src/mapper.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ import 'package:dart_json_mapper/src/model/index.dart';
55

66
import 'class_info.dart';
77
import 'errors.dart';
8-
import 'globals.dart';
9-
import 'json_map.dart';
108
import 'logic/converter_handler.dart';
119
import 'logic/deserialization_handler.dart';
1210
import 'logic/property_handler.dart';

mapper/lib/src/model/adapters.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import 'package:reflectable/src/reflectable_builder_based.dart'
1313
show ReflectorData;
1414

1515
import '../model/index.dart' show Enum;
16-
import '../class_info.dart';
1716
import '../globals.dart';
1817
import 'converters.dart';
1918
import 'type_info.dart';

mapper/lib/src/model/annotations.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import 'package:meta/meta_meta.dart';
22
import 'package:reflectable/reflectable.dart';
33

4-
import '../identifier_casing.dart';
54
import 'index.dart';
65

76
/// [jsonConstructor] is used as a shorthand metadata w/o "()"

mapper/lib/src/model/converters/bigint_converter.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import '../index.dart';
2-
import 'base_converter.dart';
32

43
const bigIntConverter = BigIntConverter();
54

mapper/lib/src/model/converters/date_converter.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import 'package:intl/intl.dart';
22

33
import '../index.dart';
4-
import 'base_converter.dart';
54

65
const dateConverter = DateConverter();
76

mapper/lib/src/model/converters/default_converter.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import 'dart:convert' show JsonEncoder;
22

33
import '../index.dart';
4-
import 'base_converter.dart';
54

65
const defaultConverter = DefaultConverter();
76

mapper/lib/src/model/converters/default_iterable_converter.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import '../index.dart';
2-
import 'base_converter.dart';
32

43
final defaultIterableConverter = DefaultIterableConverter();
54

0 commit comments

Comments
 (0)