Controller generator #506
Merged
Controller generator #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandre
force-pushed
the
scaffold-controller
branch
2 times, most recently
from
a78704f to
e50b078
Compare
Merged
mandre
commented
Sep 11, 2025
mandre
commented
Sep 11, 2025
Merged
mandre
force-pushed
the
scaffold-controller
branch
3 times, most recently
from
97957e8 to
b0cb9fc
Compare
Collaborator
Author
|
I've used this generator to work on the FWIW, this generator is a HUGE time saver when working on new controllers. |
There were a few additional resources we could generate based on the list of resources passed to the generator. Let's do this. It minimizes the needed steps when working on new controllers, and makes contributions easier.
Run `make generate-resources`. Left it in a separate commit to see that the files under the control of the generator didn't change in any meaningful way.
For new controllers, we need to re-generate the OLM bundle manifest so that it knows about the new CRDs. We now have a dedicated `generate-bundle` target for it. We could it a dependency of the `generate` target so that it's always up-to-date and checked in CI via the `verify-generated` target, however I think it's a bad idea because it would mean installing the operator-sdk in every CI run which is costly for no real gain: the manifest is always generated (and thus up-to-date) when building the OLM bundle.
Introduce a controller scaffolding tool that does most of the heavy work when writing a new controller. It asks a series of questions, then generates stubs for the API, controller implementation, tests and client code.
mandre
force-pushed
the
scaffold-controller
branch
from
b0cb9fc to
5c76eac
Compare
Collaborator
Author
|
I'm going to merge this, as other PRs depend on it. If there are adjustment to make, we can do them in follow-up PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a controller scaffolding tool that does most of the heavywork when writing a new controller. It asks a series of questions, then generates stubs for the API, controller implementation, tests and client code.
To run the scaffolding tool: