VolumeType: implement API, controller and tests

Author: mandre

api/v1alpha1/volumetype_types.go

@@ -29,13 +29,15 @@ type VolumeTypeResourceSpec struct {
 	// +optional
 	Description *string `json:"description,omitempty"`
 
-	// TODO(scaffolding): Add more types.
-	// To see what is supported, you can take inspiration from the CreateOpts stucture from
-	// github.com/gophercloud/gophercloud/v2/openstack/blockstorage/v3/volumetypes
-	//
-	// Until you have implemented mutability for the field, you must add a CEL validation
-	// preventing the field being modified:
-	// `// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="<fieldname> is immutable"`
+	// extraSpecs is a map of key-value pairs that define extra specifications for the volume type.
+	// +kubebuilder:validation:MaxItems:=32
+	// +listType=atomic
+	// +optional
+	ExtraSpecs []VolumeTypeExtraSpec `json:"extraSpecs,omitempty"`
+
+	// isPublic indicates whether the volume type is public.
+	// +optional
+	IsPublic *bool `json:"isPublic,omitempty"`
 }
 
 // VolumeTypeFilter defines an existing resource by its properties
@@ -51,9 +53,9 @@ type VolumeTypeFilter struct {
 	// +optional
 	Description *string `json:"description,omitempty"`
 
-	// TODO(scaffolding): Add more types.
-	// To see what is supported, you can take inspiration from the ListOpts stucture from
-	// github.com/gophercloud/gophercloud/v2/openstack/blockstorage/v3/volumetypes
+	// isPublic indicates whether the VolumeType is public.
+	// +optional
+	IsPublic *bool `json:"isPublic,omitempty"`
 }
 
 // VolumeTypeResourceStatus represents the observed state of the resource.
@@ -68,7 +70,37 @@ type VolumeTypeResourceStatus struct {
 	// +optional
 	Description string `json:"description,omitempty"`
 
-	// TODO(scaffolding): Add more types.
-	// To see what is supported, you can take inspiration from the VolumeType stucture from
-	// github.com/gophercloud/gophercloud/v2/openstack/blockstorage/v3/volumetypes
+	// extraSpecs is a map of key-value pairs that define extra specifications for the volume type.
+	// +kubebuilder:validation:MaxItems:=32
+	// +listType=atomic
+	// +optional
+	ExtraSpecs []VolumeTypeExtraSpecStatus `json:"extraSpecs"`
+
+	// isPublic indicates whether the VolumeType is public.
+	// +optional
+	IsPublic *bool `json:"isPublic"`
+}
+
+type VolumeTypeExtraSpec struct {
+	// name is the name of the extraspec
+	// +kubebuilder:validation:MaxLength:=255
+	// +required
+	Name string `json:"name"`
+
+	// value is the value of the extraspec
+	// +kubebuilder:validation:MaxLength:=255
+	// +required
+	Value string `json:"value"`
+}
+
+type VolumeTypeExtraSpecStatus struct {
+	// name is the name of the extraspec
+	// +kubebuilder:validation:MaxLength:=255
+	// +optional
+	Name string `json:"name,omitempty"`
+
+	// value is the value of the extraspec
+	// +kubebuilder:validation:MaxLength:=255
+	// +optional
+	Value string `json:"value,omitempty"`
 }

api/v1alpha1/zz_generated.deepcopy.go

@@ -96,6 +96,10 @@ spec:
                         maxLength: 255
                         minLength: 1
                         type: string
+                      isPublic:
+                        description: isPublic indicates whether the VolumeType is
+                          public.
+                        type: boolean
                       name:
                         description: name of the existing resource
                         maxLength: 255
@@ -155,6 +159,29 @@ spec:
                     maxLength: 255
                     minLength: 1
                     type: string
+                  extraSpecs:
+                    description: extraSpecs is a map of key-value pairs that define
+                      extra specifications for the volume type.
+                    items:
+                      properties:
+                        name:
+                          description: name is the name of the extraspec
+                          maxLength: 255
+                          type: string
+                        value:
+                          description: value is the value of the extraspec
+                          maxLength: 255
+                          type: string
+                      required:
+                      - name
+                      - value
+                      type: object
+                    maxItems: 32
+                    type: array
+                    x-kubernetes-list-type: atomic
+                  isPublic:
+                    description: isPublic indicates whether the volume type is public.
+                    type: boolean
                   name:
                     description: |-
                       name will be the name of the created resource. If not specified, the
@@ -271,6 +298,26 @@ spec:
                       resource.
                     maxLength: 1024
                     type: string
+                  extraSpecs:
+                    description: extraSpecs is a map of key-value pairs that define
+                      extra specifications for the volume type.
+                    items:
+                      properties:
+                        name:
+                          description: name is the name of the extraspec
+                          maxLength: 255
+                          type: string
+                        value:
+                          description: value is the value of the extraspec
+                          maxLength: 255
+                          type: string
+                      type: object
+                    maxItems: 32
+                    type: array
+                    x-kubernetes-list-type: atomic
+                  isPublic:
+                    description: isPublic indicates whether the VolumeType is public.
+                    type: boolean
                   name:
                     description: name is a Human-readable name for the resource. Might
                       not be unique.