-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge changes from Josh Juneau's copy #14
Comments
I started on this at a branch of my own repo but it is quite a bit of work. At least in the early chapters, we gain a lot of material. |
@jeff5 would you consider merging this into trunk? I know it's not finished, but they are mostly incremental imrpovements, right? I can take a look, I presume you have your hands pretty full with the beta. |
@adamburkegh : Sorry, I'm terrible for starting things I don't have time to finish. I thought it would be mechanical to do the whole book, but each chapter brings its own twists, and I ran out of time. The problem here is that it's mostly a routine job, if a bit fiddly, and I'd got into a sort of rhythm of what to do ... I'd be happy to share, except by the time you asked I'd mostly lost the process. It involved a lot of supervised global replacement using regexes, and a fair amount of by-hand drudgery. I've spent some time recovering my technique. Firstly, the target state for each chapter is:
I was working between (my local of) the book repo and a clone of Josh's repo. Basically my technique is to bring corresponding sources in both places to the one sentence-per-line state, and by differencing (kdiff3), figure out what bulk changes can be done to either to minimise the red. There is some word-processor damage to spot. When I've got the differences down to proper editorial content, I use merge by sentences (kdiff3 again) generally preferring Josh's copy. |
Grrr! Github has closed this because I referenced it in the commit (I think). However, I've only updated chapters 1-5. As each file seems to take a good few hours, it makes sense to do them as separate commits or PRs. It is right they should reference this, so let's keep re-opening it. |
@jeff5 All fair enough. Offer's still open for the other chapters if you like. |
Offer gratefully accepted. And a happy New Year to you. Please announce your picks here (just in case I get the urge too). I think with that last commit (and the tricky merge I gave myself) I have removed the blockage I was being to contribution. I think we should do this (i.e. get roughly level with the paper book) before trying to advance the content into 2.7/3 territory. I made a note of useful regexes. None is safe for "replace all" :
|
I have found a later version of the book in a repo belonging to Josh Juneau than the one we are building on. :( This version is much closer to the paper edition.
It will take some careful work to merge Josh's into this repository, because of fixes made here that that version lacks. (I think that's the right thing to do, but only trying will tell us if it's a lost cause.)
Believe it or not, I actually found this via the unfinished Korean translation on RTD, which I spotted contained stuff we didn't have.
The text was updated successfully, but these errors were encountered: