Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded spacings and add variables #177

Open
ChristiaanScheermeijer opened this issue Oct 7, 2022 · 0 comments
Open

Remove hardcoded spacings and add variables #177

ChristiaanScheermeijer opened this issue Oct 7, 2022 · 0 comments

Comments

@ChristiaanScheermeijer
Copy link
Collaborator

Multiple SCSS files contain generic spacings which makes it difficult to change these. Also, the actual spacings don't align with the designs as well.

Examples:

.mainPadding {
padding: 37px 56px 0;
@include responsive.desktop-small-only() {
padding: 34px 36px 36px;
}
@include responsive.tablet-only() {
padding: 34px 24px 24px;
}

.relatedVideos {
padding: 37px 56px 0;
padding-bottom: 16px;
@include responsive.desktop-small-only() {
padding: 34px;
}
@include responsive.tablet-only() {
padding: 34px 24px;
}
@include responsive.mobile-only() {
padding: 16px;
}
}

.shelfContainer {
position: relative;
padding: 12px 56px;
&.featured {
padding: 12px 20%;
}
@include responsive.mobile-only() {
padding: 8px 60px 8px variables.$base-spacing;
&.featured {
padding: 24px variables.$base-spacing;

The designs have the following spacings:

  • Mobile (<768): 16px
  • Tablet (>768 & 1024): 24px
  • Desktop (>1024): 56px
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant