optimize bundle size #66
Conversation
|
Tests still pass: npm run test
> json-logic-js@1.2.2 test /Users/andy/work/js/json-logic-js
> gulp test
[21:33:26] Using gulpfile ~/work/js/json-logic-js/gulpfile.js
[21:33:26] Starting 'test'...
Using cached applies() tests
Using cached rule_like() tests
Including 39 rule_like() tests
Including 275 applies() tests
Summary:
┌────────────────────────────────────────────┬────────┬────────┬───────┬─────────┐
│ File │ Failed │ Passed │ Total │ Runtime │
├────────────────────────────────────────────┼────────┼────────┼───────┼─────────┤
│ /Users/andy/work/js/json-logic-js/logic.js │ 0 │ 345 │ 345 │ 114 │
└────────────────────────────────────────────┴────────┴────────┴───────┴─────────┘
[21:33:27] Finished 'test' after 1.33 s |
| * @return {Function} Operator function as specified by param | ||
| */ | ||
| function generateBinaryOperation(operations, operator) { | ||
| operations[operator] = new Function("a", "b", "return a" + operator + "b;"); |
There was a problem hiding this comment.
Isn't this equivalent of eval the code. I do understand the difference between eval & new Function (closure in new Function), but the concern that many users like me would have for avoiding eval & new Function would be around Content Security Policy
Read https://developer.chrome.com/extensions/contentSecurityPolicy#JSEval for more info
There was a problem hiding this comment.
Thanks for your feedback @computnik
Well, eval has access to current scope and local variables, in contrast to the new Function constructor - which has not!
This difference is very often miss-understood and has plenty of discussions on the web already.
Regarding CSP, your are right, it could make problems, especially in chrome.
https://stackoverflow.com/questions/4599857/are-eval-and-new-function-the-same-thing
There was a problem hiding this comment.
Anyway meanwhile we have forked and completely rewrote this project and I added JSON-Schemas for all operators.
https://github.com/axa-ch/json-logic-js
Really great tool.
I'm just keen if the bundle size could be reduzed by:
Before:
https://bundlephobia.com/result?p=json-logic-js@1.2.2
Now:
4033bytes/3.94kBMinified - https://skalman.github.io/UglifyJS-online/1534bytes/1.498kBMinified + Gzipped (level 6) - https://dafrok.github.io/gzip-size-online/