Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you be interested in a code merge? (json-logic-engine) #119

Open
TotalTechGeek opened this issue Dec 16, 2022 · 0 comments
Open

Would you be interested in a code merge? (json-logic-engine) #119

TotalTechGeek opened this issue Dec 16, 2022 · 0 comments

Comments

@TotalTechGeek
Copy link

Hello!

I am and have been a huge fan of JSON Logic & the language you've designed.

For a while I've maintained an alternative JSON Logic implementation, and I'm curious if there's any interest in potentially doing a code merge? Introducing some of the work done for json-logic-engine into json-logic-js?

I would be happy to make efforts to ensure that any remaining differences are removed, mainly just:

  • Empty Arrays are truthy in mainline json-logic.
  • "all" with zero items evaluates to true

However, my codebase is not designed for as much compatibility as your project is (it most certainly would not work with IE8), though it should be able to run in all currently supported web browsers.

If you'd prefer for our projects to remain separate, there won't be any hard feelings 😄.

@TotalTechGeek TotalTechGeek changed the title Would you be interested in a code merge? Would you be interested in a code merge? (json-logic-engine) Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant