Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gulp-rollup): update rollup and gulp-rollup options #190

Merged
merged 1 commit into from
Sep 16, 2017
Merged

fix(gulp-rollup): update rollup and gulp-rollup options #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions generators/app/templates/_package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"del": "^2.2.2",
"gulp": "^3.9.1",
"gulp-rename": "^1.2.2",
"gulp-rollup": "^2.11.0",
"gulp-rollup": "^2.15.0",
"jasmine-core": "~2.5.2",
"jasmine-spec-reporter": "~3.2.0",
"karma": "~1.4.1",
Expand All @@ -54,7 +54,7 @@
"node-sass-tilde-importer": "^1.0.0",
"node-watch": "^0.5.2",
"protractor": "~5.1.0",
"rollup": "^0.41.6",
"rollup": "^0.49.3",
"run-sequence": "^1.2.2",
"rxjs": "^5.1.0",
"ts-node": "~2.0.0",
Expand Down
24 changes: 12 additions & 12 deletions generators/app/templates/gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ gulp.task('rollup:fesm', function () {
.pipe(rollup({

// Bundle's entry point
// See https://github.com/rollup/rollup/wiki/JavaScript-API#entry
entry: `${buildFolder}/index.js`,
// See "input" in https://rollupjs.org/#core-functionality
input: `${buildFolder}/index.js`,

// Allow mixing of hypothetical and actual files. "Actual" files can be files
// accessed by Rollup or produced by plugins further down the chain.
Expand All @@ -81,14 +81,14 @@ gulp.task('rollup:fesm', function () {
allowRealFiles: true,

// A list of IDs of modules that should remain external to the bundle
// See https://github.com/rollup/rollup/wiki/JavaScript-API#external
// See "external" in https://rollupjs.org/#core-functionality
external: [
'@angular/core',
'@angular/common'
],

// Format of generated bundle
// See https://github.com/rollup/rollup/wiki/JavaScript-API#format
// See "format" in https://rollupjs.org/#core-functionality
format: 'es'
}))
.pipe(gulp.dest(distFolder));
Expand All @@ -104,8 +104,8 @@ gulp.task('rollup:umd', function () {
.pipe(rollup({

// Bundle's entry point
// See https://github.com/rollup/rollup/wiki/JavaScript-API#entry
entry: `${buildFolder}/index.js`,
// See "input" in https://rollupjs.org/#core-functionality
input: `${buildFolder}/index.js`,

// Allow mixing of hypothetical and actual files. "Actual" files can be files
// accessed by Rollup or produced by plugins further down the chain.
Expand All @@ -114,26 +114,26 @@ gulp.task('rollup:umd', function () {
allowRealFiles: true,

// A list of IDs of modules that should remain external to the bundle
// See https://github.com/rollup/rollup/wiki/JavaScript-API#external
// See "external" in https://rollupjs.org/#core-functionality
external: [
'@angular/core',
'@angular/common'
],

// Format of generated bundle
// See https://github.com/rollup/rollup/wiki/JavaScript-API#format
// See "format" in https://rollupjs.org/#core-functionality
format: 'umd',

// Export mode to use
// See https://github.com/rollup/rollup/wiki/JavaScript-API#exports
// See "exports" in https://rollupjs.org/#danger-zone
exports: 'named',

// The name to use for the module for UMD/IIFE bundles
// (required for bundles with exports)
// See https://github.com/rollup/rollup/wiki/JavaScript-API#modulename
moduleName: '<%= props.libraryName.original %>',
// See "name" in https://rollupjs.org/#core-functionality
name: '<%= props.libraryName.original %>',

// See https://github.com/rollup/rollup/wiki/JavaScript-API#globals
// See "globals" in https://rollupjs.org/#core-functionality
globals: {
typescript: 'ts'
}
Expand Down