Skip to content

Commit f44cbb3

Browse files
lgriffeealex-pageaaronccasanova
authored andcommitted
Add new z-index token names (Shopify#8245)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? We want to rename these tokens in v11. By adding the new names in v10 we can break up the major version bump into more manageable chunks (we can create and run migrations for the values in v10 and then just remove the values in the launch of v11). <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> <!-- ℹ️ Delete the following for small / trivial changes --> Adds a set of identical z-index tokens with the names `--p-z-index-*` (vs. `--p-z-*`) --------- Co-authored-by: Alex Page <hi@alexpage.dev> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
1 parent e21b1a2 commit f44cbb3

File tree

2 files changed

+41
-0
lines changed

2 files changed

+41
-0
lines changed

.changeset/fuzzy-timers-kneel.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@shopify/polaris-tokens': minor
3+
---
4+
5+
Added new z-index tokens that will be the default in v7.0.0

polaris-tokens/src/token-groups/zIndex.ts

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,42 @@
11
import type {TokenGroup} from '../types';
22

33
export const zIndex = {
4+
'z-index-1': {
5+
value: '100',
6+
},
7+
'z-index-2': {
8+
value: '400',
9+
},
10+
'z-index-3': {
11+
value: '510',
12+
},
13+
'z-index-4': {
14+
value: '512',
15+
},
16+
'z-index-5': {
17+
value: '513',
18+
},
19+
'z-index-6': {
20+
value: '514',
21+
},
22+
'z-index-7': {
23+
value: '515',
24+
},
25+
'z-index-8': {
26+
value: '516',
27+
},
28+
'z-index-9': {
29+
value: '517',
30+
},
31+
'z-index-10': {
32+
value: '518',
33+
},
34+
'z-index-11': {
35+
value: '519',
36+
},
37+
'z-index-12': {
38+
value: '520',
39+
},
440
'z-1': {
541
value: '100',
642
},

0 commit comments

Comments
 (0)