Skip to content

No longer export the internal methods from SQLite3 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2018

Conversation

Dretch
Copy link
Contributor

@Dretch Dretch commented Oct 7, 2018

No description provided.

@justinwoo
Copy link
Owner

I guess this is fine, but do you mind moving them to an internal module?

@Dretch
Copy link
Contributor Author

Dretch commented Oct 8, 2018

As you desire (well, perhaps!).

My original motivation was to make the docs easier to read by removing the internal functions. Both using an Internal module and just not-exporting the internal functions will achieve that.

@justinwoo
Copy link
Owner

Thanks!

@justinwoo justinwoo merged commit b208469 into justinwoo:master Oct 8, 2018
@justinwoo
Copy link
Owner

Published here: https://pursuit.purescript.org/packages/purescript-node-sqlite3/4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants