Bug fix: The key mappings that are <silent> prevent Vim from asking the user to enter the encryption key #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… '<cmd>call'. Problem: Dirvish key mappings that are <silent> prevent Vim from asking the user to enter an encryption key when an encrypted file is opened from Dirvish (`:help encryption`). Solution: Remove <silent> from the key mappings that call 'dirvish#open()' and replace ':call' with '<cmd>call'.
jamescherti
changed the title
jamescherti
changed the title
|
Thanks! |
jamescherti
changed the title
monadnocking
added a commit
to monadnocking/vim-dirvish
that referenced
this pull request
Mar 29, 2024
Problem:
`{Visual}O` and similar commands only operate on a single file
after 6233243 (fix(mappings): prefer <cmd>, drop <silent> justinmk#235,
2022-12-08).
Solution:
Use `line('v')` and `line('.')` to get the visual range when
the `<Cmd>` mappings are used.
monadnocking
added a commit
to monadnocking/vim-dirvish
that referenced
this pull request
Mar 29, 2024
… file
Problem:
`{Visual}O` and similar commands only operate on a single file
after 6233243 (fix(mappings): prefer <cmd>, drop <silent> justinmk#235,
2022-12-08).
Solution:
Use `line('v')` and `line('.')` to get the visual range when
the `<Cmd>` mappings are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The Dirvish key mappings that are
<silent>prevent Vim from asking the user to enter the encryption key when an encrypted file is opened from Dirvish (:help encryption).Solution: Remove
<silent>from the key mappings that calldirvish#open()and replace:callwith<cmd>call.