Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: The key mappings that are <silent> prevent Vim from asking the user to enter the encryption key #235

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Conversation

jamescherti
Copy link
Contributor

@jamescherti jamescherti commented Dec 8, 2022

Problem: The Dirvish key mappings that are <silent> prevent Vim from asking the user to enter the encryption key when an encrypted file is opened from Dirvish (:help encryption).

Solution: Remove <silent> from the key mappings that call dirvish#open() and replace :call with <cmd>call.

… '<cmd>call'.

Problem:
Dirvish key mappings that are <silent> prevent
Vim from asking the user to enter an encryption key when an encrypted
file is opened from Dirvish (`:help encryption`).

Solution:
Remove <silent> from the key mappings that call
'dirvish#open()' and replace ':call' with '<cmd>call'.
@jamescherti jamescherti changed the title dirvish#open() key mappings: Remove <silent> and replace ':call' with '<cmd>call' Bug fix: 'dirvish#open()' key mappings prevent Vim from asking the user to enter an encryption key Dec 8, 2022
@jamescherti jamescherti changed the title Bug fix: 'dirvish#open()' key mappings prevent Vim from asking the user to enter an encryption key Bug fix: The key mappings that are <silent> prevent Vim from asking the user to enter an encryption key Dec 8, 2022
@justinmk justinmk merged commit 6233243 into justinmk:master Dec 8, 2022
@justinmk
Copy link
Owner

justinmk commented Dec 8, 2022

Thanks!

@jamescherti jamescherti changed the title Bug fix: The key mappings that are <silent> prevent Vim from asking the user to enter an encryption key Bug fix: The key mappings that are <silent> prevent Vim from asking the user to enter the encryption key Dec 9, 2022
monadnocking added a commit to monadnocking/vim-dirvish that referenced this pull request Mar 29, 2024
Problem:
`{Visual}O` and similar commands only operate on a single file
after 6233243 (fix(mappings): prefer <cmd>, drop <silent> justinmk#235,
2022-12-08).

Solution:
Use `line('v')` and `line('.')` to get the visual range when
the `<Cmd>` mappings are used.
monadnocking added a commit to monadnocking/vim-dirvish that referenced this pull request Mar 29, 2024
… file

Problem:
`{Visual}O` and similar commands only operate on a single file
after 6233243 (fix(mappings): prefer <cmd>, drop <silent> justinmk#235,
2022-12-08).

Solution:
Use `line('v')` and `line('.')` to get the visual range when
the `<Cmd>` mappings are used.
justinmk pushed a commit that referenced this pull request Apr 3, 2024
Problem:
`{Visual}O` and similar commands only operate on a single file
since 6233243 #235.

Solution:
Use `line('v')` and `line('.')` to get the visual range when
the `<Cmd>` mappings are used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants