Skip to content

Commit c8ea99f

Browse files
josephperrottmatsko
authored andcommitted
build: bump check version requirements for bazel and rules_nodejs (angular#33966)
PR Close angular#33966
1 parent 7d579b9 commit c8ea99f

File tree

1 file changed

+2
-17
lines changed

1 file changed

+2
-17
lines changed

WORKSPACE

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -26,25 +26,10 @@ Try running `yarn bazel` instead.
2626
(If you did run that, check that you've got a fresh `yarn install`)
2727
2828
""",
29-
minimum_bazel_version = "0.27.0",
29+
minimum_bazel_version = "1.1.0",
3030
)
3131

32-
# The NodeJS rules version must be at least the following version because:
33-
# - 0.15.2 Re-introduced the prod_only attribute on yarn_install
34-
# - 0.15.3 Includes a fix for the `jasmine_node_test` rule ignoring target tags
35-
# - 0.16.8 Supports npm installed bazel workspaces
36-
# - 0.26.0 Fix for data files in yarn_install and npm_install
37-
# - 0.27.12 Adds NodeModuleSources provider for transtive npm deps support
38-
# - 0.30.0 yarn_install now uses symlinked node_modules with new managed directories Bazel 0.26.0 feature
39-
# - 0.31.1 entry_point attribute of nodejs_binary & rollup_bundle is now a label
40-
# - 0.32.0 yarn_install and npm_install no longer puts build files under symlinked node_modules
41-
# - 0.32.1 remove override of @bazel/tsetse & exclude typescript lib declarations in node_module_library transitive_declarations
42-
# - 0.32.2 resolves bug in @bazel/hide-bazel-files postinstall step
43-
# - 0.34.0 introduces protractor rule
44-
# - 0.37.1 windows fixes
45-
# - 0.38.2 Adds NpmPackageInfo & JSNamedModuleInfo providers
46-
# - 0.38.3 all providers loaded from //:providers.bzl
47-
check_rules_nodejs_version(minimum_version_string = "0.38.3")
32+
check_rules_nodejs_version(minimum_version_string = "0.40.0")
4833

4934
# Setup the Node.js toolchain
5035
node_repositories(

0 commit comments

Comments
 (0)