From 6cdcfd57b81c812e6187278dfd1667024b4e9403 Mon Sep 17 00:00:00 2001
From: martincostello <martin@martincostello.com>
Date: Mon, 5 Feb 2024 15:07:21 +0000
Subject: [PATCH] Address review feedback

Address PR feedback from #1308.
---
 .../AwsConfigResolvingClientFactory.cs           |  1 -
 .../IServiceCollectionExtensions.cs              | 16 ++++++++--------
 .../JustSaying.Extensions.Aws.csproj             |  2 +-
 .../PublicAPI/net6.0/PublicAPI.Shipped.txt       |  0
 .../PublicAPI/net6.0/PublicAPI.Unshipped.txt     |  3 +++
 5 files changed, 12 insertions(+), 10 deletions(-)
 create mode 100644 src/JustSaying.Extensions.Aws/PublicAPI/net6.0/PublicAPI.Shipped.txt
 create mode 100644 src/JustSaying.Extensions.Aws/PublicAPI/net6.0/PublicAPI.Unshipped.txt

diff --git a/src/JustSaying.Extensions.Aws/AwsConfigResolvingClientFactory.cs b/src/JustSaying.Extensions.Aws/AwsConfigResolvingClientFactory.cs
index aabac009c..c5b11cad4 100644
--- a/src/JustSaying.Extensions.Aws/AwsConfigResolvingClientFactory.cs
+++ b/src/JustSaying.Extensions.Aws/AwsConfigResolvingClientFactory.cs
@@ -34,5 +34,4 @@ public IAmazonSQS GetSqsClient(RegionEndpoint region)
         }
         return sqs;
     }
-
 }
diff --git a/src/JustSaying.Extensions.Aws/IServiceCollectionExtensions.cs b/src/JustSaying.Extensions.Aws/IServiceCollectionExtensions.cs
index 398cf520d..4bd56e542 100644
--- a/src/JustSaying.Extensions.Aws/IServiceCollectionExtensions.cs
+++ b/src/JustSaying.Extensions.Aws/IServiceCollectionExtensions.cs
@@ -1,3 +1,4 @@
+using System.ComponentModel;
 using Amazon.SimpleNotificationService;
 using Amazon.SQS;
 using JustSaying;
@@ -5,7 +6,6 @@
 using JustSaying.Extensions.Aws;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection.Extensions;
-using System.ComponentModel;
 
 namespace Microsoft.Extensions.DependencyInjection;
 
@@ -16,7 +16,7 @@ namespace Microsoft.Extensions.DependencyInjection;
 public static class IServiceCollectionExtensions
 {
     /// <summary>
-    /// Adds JustSaying services to the service collection.
+    /// Adds JustSaying services to the service collection using AWS configuration.
     /// </summary>
     /// <param name="services">The <see cref="IServiceCollection"/> to add JustSaying services to.</param>
     /// <param name="configuration">The <see cref="IConfiguration"/> used to setup AWS configuration.</param>
@@ -25,7 +25,7 @@ public static class IServiceCollectionExtensions
     /// The <see cref="IServiceCollection"/> specified by <paramref name="services"/>.
     /// </returns>
     /// <exception cref="ArgumentNullException">
-    /// <paramref name="services"/> is <see langword="null"/>.
+    /// <paramref name="services"/>, <paramref name="configuration"/> or <paramref name="builderConfig"/> is <see langword="null"/>.
     /// </exception>
     public static void AddJustSayingWithAwsConfig(this IServiceCollection services, IConfiguration configuration, Action<MessagingBusBuilder> builderConfig)
     {
@@ -48,7 +48,7 @@ public static void AddJustSayingWithAwsConfig(this IServiceCollection services,
     }
 
     /// <summary>
-    /// Adds JustSaying services to the service collection.
+    /// Adds JustSaying services to the service collection using AWS configuration.
     /// </summary>
     /// <param name="services">The <see cref="IServiceCollection"/> to add JustSaying services to.</param>
     /// <param name="configuration">The <see cref="IConfiguration"/> used to setup AWS configuration.</param>
@@ -57,21 +57,21 @@ public static void AddJustSayingWithAwsConfig(this IServiceCollection services,
     /// The <see cref="IServiceCollection"/> specified by <paramref name="services"/>.
     /// </returns>
     /// <exception cref="ArgumentNullException">
-    /// <paramref name="services"/> is <see langword="null"/>.
+    /// <paramref name="services"/>, <paramref name="configuration"/> or <paramref name="builderConfig"/> is <see langword="null"/>.
     /// </exception>
     public static void AddJustSayingWithAwsConfig(this IServiceCollection services, IConfiguration configuration, Action<MessagingBusBuilder, IServiceProvider> builderConfig)
     {
-        if(services is null)
+        if (services is null)
         {
             throw new ArgumentNullException(nameof(services));
         }
 
-        if(configuration is null)
+        if (configuration is null)
         {
             throw new ArgumentNullException(nameof(configuration));
         }
 
-        if(builderConfig is null)
+        if (builderConfig is null)
         {
             throw new ArgumentNullException(nameof(builderConfig));
         }
diff --git a/src/JustSaying.Extensions.Aws/JustSaying.Extensions.Aws.csproj b/src/JustSaying.Extensions.Aws/JustSaying.Extensions.Aws.csproj
index cdaec9bc3..58e0705d6 100644
--- a/src/JustSaying.Extensions.Aws/JustSaying.Extensions.Aws.csproj
+++ b/src/JustSaying.Extensions.Aws/JustSaying.Extensions.Aws.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <IsShipping>true</IsShipping>
-    <TargetFramework>netstandard2.0</TargetFramework>
+    <TargetFrameworks>netstandard2.0;net6.0</TargetFrameworks>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/JustSaying.Extensions.Aws/PublicAPI/net6.0/PublicAPI.Shipped.txt b/src/JustSaying.Extensions.Aws/PublicAPI/net6.0/PublicAPI.Shipped.txt
new file mode 100644
index 000000000..e69de29bb
diff --git a/src/JustSaying.Extensions.Aws/PublicAPI/net6.0/PublicAPI.Unshipped.txt b/src/JustSaying.Extensions.Aws/PublicAPI/net6.0/PublicAPI.Unshipped.txt
new file mode 100644
index 000000000..8b9487fdb
--- /dev/null
+++ b/src/JustSaying.Extensions.Aws/PublicAPI/net6.0/PublicAPI.Unshipped.txt
@@ -0,0 +1,3 @@
+Microsoft.Extensions.DependencyInjection.IServiceCollectionExtensions
+static Microsoft.Extensions.DependencyInjection.IServiceCollectionExtensions.AddJustSayingWithAwsConfig(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, Microsoft.Extensions.Configuration.IConfiguration configuration, System.Action<JustSaying.MessagingBusBuilder, System.IServiceProvider> builderConfig) -> void
+static Microsoft.Extensions.DependencyInjection.IServiceCollectionExtensions.AddJustSayingWithAwsConfig(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, Microsoft.Extensions.Configuration.IConfiguration configuration, System.Action<JustSaying.MessagingBusBuilder> builderConfig) -> void
\ No newline at end of file