Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more descriptive name for EmptyErrror #8

Open
Benjmhart opened this issue Jan 25, 2021 · 2 comments
Open

more descriptive name for EmptyErrror #8

Benjmhart opened this issue Jan 25, 2021 · 2 comments
Assignees
@kozross
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@Benjmhart
Copy link
Contributor

this should be InvalidJson Provided
@Benjmhart
Copy link
Contributor Author

actually upon further inspection, this appears to be the error received if a given property name is not present.

again, more descriptiveness is needed.

@kozross kozross self-assigned this Jan 26, 2021
@kozross kozross added bug Something isn't working documentation Improvements or additions to documentation labels Jan 26, 2021
@kozross
Copy link
Contributor

kozross commented Jan 26, 2021

This is actually more complicated - it's an artifact of how we combine non-determinism and error handling. It definitely needs fixing, and should also make the whole codebase cleaner to boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kozross kozross

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kozross @Benjmhart