Skip to content

Fix invalid schema for jupyterlite_sphinx_strip tag when strip_tagged_cells is True #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Fix invalid schema for jupyterlite_sphinx_strip tag when strip_tagged_cells is True #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0614834
Fix doc mention of `jupyterlite_sphinx_strip` tag
agriyakhetarpal Jul 18, 2024
5dffe6d
Fix invalid schema when parsing notebooks
agriyakhetarpal Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ and then by tagging the cells you want to strip with the tag `jupyterlite_sphinx
of the cell, like this:

```json
{
"metadata": {
"tags": [
"jupyterlite_sphinx_strip": "true"
"jupyterlite_sphinx_strip"
]
}
```
Expand All @@ -89,7 +89,7 @@ in the JupyterLite console:
"cell_type": "markdown",
"metadata": {
"tags": [
"jupyterlite_sphinx_strip": "true"
"jupyterlite_sphinx_strip"
]
},
"source": [
Expand Down
4 changes: 1 addition & 3 deletions jupyterlite_sphinx/jupyterlite_sphinx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,13 +351,11 @@ def run(self):
# is so that we don't end up removing useful data or directives that
# are not meant to be removed.

nb = nbformat.read(notebook, as_version=4)
print(f"Opened {notebook_name}")
nb = nbformat.read(notebook, as_version=4)
nb.cells = [
cell
for cell in nb.cells
if "true" not in cell.metadata.get("jupyterlite_sphinx_strip", [])
if "jupyterlite_sphinx_strip" not in cell.metadata.get("tags", [])
]
nbformat.write(nb, notebooks_dir, version=4)

Expand Down