Resolve default-encoding errors on Windows

[AA-Turner]

See PYTHONWARNDEFAULTENCODING et al. Without this change I ran into charmap errors.

A

[AA-Turner]

An alternative, given you're using Pathlib:

Suggested change

	with open(notebooks_dir / Path(notebook_unique_name), "w", encoding="utf-8") as f:
	# nbf.write incorrectly formats multiline arrays in output.
	json.dump(nb, f, indent=4, ensure_ascii=False)
	# nbf.write incorrectly formats multiline arrays in output.
	nb_json = json.dump(nb, f, indent=4, ensure_ascii=False)
	(notebooks_dir / notebook_unique_name).write_text(nb_json, encoding="utf-8")

[agriyakhetarpal]

We have nbformat as a dependency now. Can we make it write the notebook here instead of having to rely on JSON directly?

[steppi]

nbformat has been a dependency of the TryExamplesDirective from the beginning. This originally used nbformat to write the notebook, but as the comment mentions, there is an edge case it cannot handle. Arrays with multiple lines in output cells get formatted incorrectly when using nbformat to write the notebook.

[steppi]

In the suggestion above, I think it should be

nb_json = json.dumps(nb, indent=4, ensure_ascii=False)

[AA-Turner]

Yep sorry - I just made the suggestion via GH's editor, missed checking it properly.

A

[agriyakhetarpal]

Ah, thanks for the context, @steppi. I thought the problem might have been resolved by now, but that's something to look for in a different place.

[agriyakhetarpal]

We have nbformat as a dependency now. Can we make it write the notebook here instead of having to rely on JSON directly?

[steppi]

Thanks for the patch @AA-Turner. This project enforces the black codestyle; to fix the test failure you just have to run black on the file jupyterlite_sphinx.py.

[AA-Turner]

Hi -- this was just a quick fix as I'm debugging a new failure in Sphinx 7.4/SciPy -- I don't have the project checked out locally so can't easily run black/etc. Please feel free to push to this branch / whatever else is appropriate.

A

[steppi]

Thanks again for the fix @AA-Turner. I've made the formatting change so in this goes.