Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyterlab 4.1 dedent broken #15821

Closed
harper357 opened this issue Feb 19, 2024 · 2 comments · Fixed by #15898
Closed

Jupyterlab 4.1 dedent broken #15821

harper357 opened this issue Feb 19, 2024 · 2 comments · Fixed by #15898
Assignees
Labels
bug tag:Keyboard Compatibility issues with keyboards, including locale-specific and layout-specific issues tag:Regression Behavior that had been broken, was fixed, and is broken again
Milestone

Comments

@harper357
Copy link

Description

With JupyterLab <4.1, Shift+Tab would open object introspection, tab-completion if I was in a function or if I highlight part of the line it would just dedent it. However after upgrading to 4.1, it now will dedent the current line withought highlighting, so now it will open object introspection and dedent everytime I press Shift+Tab and there is no clear way to change this short cut.

I tried reverting to Jupyterlab 4.0.12 and this fixes it, so I think it might be a bug, but no one else has reported it so maybe it is just something with my setup?

I asked this on the Discourse, but have not received any reply.

Reproduce

In a code cell, indent a line. Now hit Shift+Tab to bring up the object introspection. The line gets dedented and object introspection comes up.

I created a new python3.11 virtualenv, installed Jupyterlab 4.1.1 and did the above steps.

Expected behavior

Dedents should only happen if part of the line is hightlighted like in Jupyterlab < 4.1

Context

macOS 12.3 (M1)
Chrome 121.0.6167.184
JupyterLab version: 4.1.1

@harper357 harper357 added the bug label Feb 19, 2024
Copy link

welcome bot commented Feb 19, 2024

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Feb 19, 2024
@krassowski krassowski added this to the 4.1.x milestone Feb 19, 2024
@krassowski
Copy link
Member

This is quite likely another side-effect of #14115; that pull request included mitigation for tab completion and indentation but not for dedentation.

@JasonWeill JasonWeill added tag:Regression Behavior that had been broken, was fixed, and is broken again and removed status:Needs Triage Applied to new issues that need triage labels Feb 20, 2024
@krassowski krassowski added the tag:Keyboard Compatibility issues with keyboards, including locale-specific and layout-specific issues label Feb 23, 2024
@krassowski krassowski self-assigned this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tag:Keyboard Compatibility issues with keyboards, including locale-specific and layout-specific issues tag:Regression Behavior that had been broken, was fixed, and is broken again
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants