Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard navigation difficult within Settings editor > keyboard shortcuts #15546

Open
e218736 opened this issue Dec 20, 2023 · 2 comments
Open

Comments

@e218736
Copy link
Contributor

e218736 commented Dec 20, 2023

Problem

Navigating keyboard shortcuts in settings editor using keyboard has limited functionality compared with using a mouse.

For example I am unable to interact with the shortcut keys div to enable editing the keys within the input field.

In addition, inability to focus on elements within each row using keyboard results in not being able to see or select the option to add a secondary keyboard shortcut.

Proposed Solution

Converting interactive divs to buttons to ensure tab-ability for keyboard users.
CSS styling of focus events to replicate mouse hover functionality for keyboard users.

Additional context

Discovered this whilst working on a solution to Settings editor keyboard shortcut punctuation issues so will update if other navigation issues arise

@JasonWeill
Copy link
Contributor

@e218736 Thanks for opening this! Just to be certain, which version of JupyterLab are you using? The settings editor is very different in Lab 3 compared with Lab 4, for example.

@e218736
Copy link
Contributor Author

e218736 commented Jan 3, 2024

@JasonWeill This is using Version 4.1.0a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants