You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There has already been some discussions about testing for breaking changes (will add links to this issue later as needed if any).
However most of the time this requires manually checking and thinking about the implications of the proposed changes in a PR.
Ideally there could be some automated check that would help catch such changes.
Proposed Solution
Maybe the existing Galata tests could be extended to also check for third-party mimerender and theme extensions.
The main issue would be to choose such third-party extensions that are considered stable enough and maintained to be included in the automated test suite. For example using one of the extensions from https://github.com/jupyterlab/jupyter-renderers. For the theme maybe there could be a "semi-official" one under the jupyterlab organization (or generated from https://github.com/jupyterlab/extension-cookiecutter-ts).
The alternative is to remember to test with such third-party extensions during the JupyterLab alpha cycle to catch potential issues early.
Additional context
Linking to #13461 as an example of an unintentional breaking change for third-party theme extensions.
Also linking to #12581 which unbumped the major version of rendermime-interfaces to avoid extension authors to manually update their extension for JupyterLab 4.0.
The text was updated successfully, but these errors were encountered:
Problem
There has already been some discussions about testing for breaking changes (will add links to this issue later as needed if any).
However most of the time this requires manually checking and thinking about the implications of the proposed changes in a PR.
Ideally there could be some automated check that would help catch such changes.
Proposed Solution
Maybe the existing Galata tests could be extended to also check for third-party mimerender and theme extensions.
The main issue would be to choose such third-party extensions that are considered stable enough and maintained to be included in the automated test suite. For example using one of the extensions from https://github.com/jupyterlab/jupyter-renderers. For the theme maybe there could be a "semi-official" one under the
jupyterlab
organization (or generated from https://github.com/jupyterlab/extension-cookiecutter-ts).The alternative is to remember to test with such third-party extensions during the JupyterLab alpha cycle to catch potential issues early.
Additional context
Linking to #13461 as an example of an unintentional breaking change for third-party theme extensions.
Also linking to #12581 which unbumped the major version of
rendermime-interfaces
to avoid extension authors to manually update their extension for JupyterLab 4.0.The text was updated successfully, but these errors were encountered: