Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows on arm support #735

Closed
xgdgsc opened this issue Dec 7, 2023 · 4 comments · Fixed by #736
Closed

Add windows on arm support #735

xgdgsc opened this issue Dec 7, 2023 · 4 comments · Fixed by #736
Labels
enhancement os:windows Problems specific to Microsoft Windows

Comments

@xgdgsc
Copy link
Contributor

xgdgsc commented Dec 7, 2023

Please consider adding windows on arm support. As electron has the support. Should work with a build configuration change like what I did at xgdgsc/Rocket.Chat.Electron@09014d0 .
@xgdgsc xgdgsc added the bug label Dec 7, 2023
@xgdgsc xgdgsc mentioned this issue Dec 7, 2023
Merged
@xgdgsc
Copy link
Contributor Author

xgdgsc commented Dec 7, 2023

Setting custom python env to my installed D:\Program Files\Python312-arm64\python.exe doesn' t seem to work. Anyway to stop the warning message. Does the restore session function rely on the python env?

@JasonWeill JasonWeill added enhancement os:windows Problems specific to Microsoft Windows and removed bug status:Needs Triage labels Dec 12, 2023
@JasonWeill JasonWeill mentioned this issue Dec 12, 2023
Closed
@xgdgsc
Copy link
Contributor Author

xgdgsc commented Dec 19, 2023 •
edited
Loading

I didn' t find the doc of creating the venv for it before. (Might be better add a link to the doc in the settings UI). After following the user guide I have the custom python env working now. So nothing seems wrong so far.

@xgdgsc
Copy link
Contributor Author

xgdgsc commented Dec 27, 2023

Thanks, I don' t know how to add it to the release workflow. Hope someone can add that.

@mbektas
Copy link
Member

mbektas commented Dec 27, 2023

I tried to create conda environment for win-arm64 but it didn't work. Looks like conda support is not fully there yet. I will revisit at another time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement os:windows Problems specific to Microsoft Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add win arm64 dist xgdgsc/jupyterlab-desktop
3 participants
@xgdgsc @mbektas @JasonWeill