Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winget packages are out of date #609

Closed
vasiljevic opened this issue Mar 10, 2023 · 11 comments · Fixed by #647
Closed

Winget packages are out of date #609

vasiljevic opened this issue Mar 10, 2023 · 11 comments · Fixed by #647

Comments

@vasiljevic
Copy link

Description

Latest version in the winget repository is 3.5.1-1, but the latest publised version is 3.6.1-2 (on March 10, 2023)

Since the version 3.6.1-1 is published on Feb 6, winget repo for jupyterlab is more than one month out of date.

Also, after installation using winget, jlab reports that new version exists and ask me to downoad it, not to upgrade using winget.

Reproduce

  1. In the Windows command prompt execute winget search jupyterlab --versions
  2. See the latest version that is not up to date

Expected behavior

It is expected not to have significant delay of new winget pachages after a new version of jupyterlab-desktop is published.

Context

  • Operating System and version: Windows 11
  • JupyterLab-Desktop version: 3.6.1-2
  • Installer: winget
@vasiljevic vasiljevic added the bug label Mar 10, 2023
@welcome
Copy link

welcome bot commented Mar 10, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@JasonWeill
Copy link

winget is a Microsoft-administered package manager. JupyterLab Desktop's manifest has been committed by @brl0 and modified by @mdanish-kh. I'm not sure whether they would be the right people to submit newer versions to winget.

@mdanish-kh
Copy link

@JasonWeill WinGet packages are entirely community maintained. There is some work to be done for microsoft/winget-pkgs#100, which would let publishers take control of their package submissions. Right now, the expectation is that publishers integrate the submission process as part of their releases or the community updates the manifests themselves.

If the maintainers want to automate the submission process and keep the package up-to-date, they can integrate winget-create (maintained by the WinGet team) as part of their release workflow. They can follow the steps outlined in the documentation and also take a look at an example of how PowerShell maintainers use winget-create to automate the submissions.

Apart from winget-create, there is also a popular community-developed GitHub Action winget-releaser maintained by @vedantmgoyal2009 for the same task.

@brl0
Copy link
Contributor

brl0 commented Apr 25, 2023

I submitted an update to the winget package. After running into some issues with WingetCreate, I tried KOMAC, the tool utilized by winget-releaser GitHub Action mentioned above, and it worked well. I have submitted #647 to add a workflow to make use of that action.

@vedantmgoyal9
Copy link

The PR by @brl0 looks good. @JasonWeill would you like to merge?

@JasonWeill JasonWeill linked a pull request May 2, 2023 that will close this issue
@JasonWeill
Copy link

@vedantmgoyal2009 I linked #647 to this issue. I have not yet added the GitHub token or forked the package as you specified, and I'm about to leave town for over a week (due primarily to JupyterCon) so I will not be available to do this until after I'm back.

@brl0
Copy link
Contributor

brl0 commented May 18, 2023

I submitted another update to the winget package. Komac makes it really easy to do, but it would be nice to have it included in GitHub Actions so that it is automatically updated. Let me know if there is anything I can do to assist with that.

@vedantmgoyal9
Copy link

@JasonWeill are you available now?

@JasonWeill
Copy link

@vedantmgoyal2009 Thanks for the follow up! I'd prefer if @mbektas take a look at PR #647 — he was also at JupyterCon.

@halr9000
Copy link

As a new user, as someone who uses winget FIRST to install everything, I was disappointed to find that the repo is out of date. Anyone working to resolve? The github actions path mentioned above sounds great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants