-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users item toolbar #379
base: main
Are you sure you want to change the base?
Users item toolbar #379
Conversation
@@ -0,0 +1,192 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is docprovider the right place for this, or should be in the collaboration
package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked myself the same question, and I put it here because it is really a document related widget, it supposed to handle the document current collaborators.
But I don't have a strong opinion on it, and can move it to collaboration
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! I wouldn't know. Maybe @davidbrochart has an opinion on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say that we should think about docprovider as enabling to use ydoc without collaboration
, so anything which is collaboration-specific should go to collaboration
unless it is impractical.
Should this be merged now while Or should this be part of a |
Right, we should probably wait for the next release. |
Looks like this repo does not make active use of GitHub milestones, but it could be useful to start using them to track such issues and improvements. I just created the following two milestones:
Feel free to move it back to the |
btw @brichet if you have a screenshot / screencast around that could be posted in the description that would be really useful, thanks! (and we could also add it to the changelog when releasing this) |
Thanks, that helped me to finish this PR, I had only tested it with jupyter-collaboration v2 and forgot to copy the styles in there. |
71edae1
to
bade577
Compare
…lay current users
…sor on Anonymous icons
- allow the default renderer to receive additional classes - rename it for consistency - avoid sending non related props to div element
70e5f92
to
c4d7d43
Compare
Copy of #378, to try to fix the
check_release
workflow.This PR provides a widget that can be used in a collaborative document to display current users.
This widget is a refactoring of a widget initially created in jupyterCAD.
Porting it to
jupyter_collaboration
has been initially discussed in jupytercad/JupyterCAD#496.EDIT:
If the widget is integrated to a notebook for example, it looks like:
Code for the notebook widget (in Jupyterlab)
The Notebook is a special case because the document model can be null when first displayed. We need to handle the
modelChange
event.packages/notebook-extension/src/index.ts
packages/notebook-extension/schema/panel.json