Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget to display users of a collaborative document #378

Closed
wants to merge 2 commits into from

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Oct 18, 2024

This PR provides a widget that can be used in a collaborative document to display current users.

This widget is a refactoring of a widget initially created in jupyterCAD.
Porting it to jupyter_collaboration has been initially discussed in jupytercad/JupyterCAD#496.

Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/jupyter_collaboration/users_item_toolbar

@brichet brichet added the enhancement New feature or request label Oct 18, 2024
@brichet
Copy link
Contributor Author

brichet commented Oct 18, 2024

bump CI

@brichet brichet closed this Oct 18, 2024
@brichet brichet reopened this Oct 18, 2024
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks so much @brichet!

@brichet brichet marked this pull request as ready for review October 19, 2024 10:07
@davidbrochart
Copy link
Collaborator

Not sure why Check Release fails?

@jtpio
Copy link
Member

jtpio commented Oct 21, 2024

Got something similar recently in jupyter-server/jupyter_releaser#585.

Recreating a new PR (with the same changes) fixed it. Not sure yet of the root cause, but it might be something to investigate if it keeps happening.

So if you close this PR and open a new one, so the PR number changes, maybe it will help.

@brichet
Copy link
Contributor Author

brichet commented Oct 21, 2024

Thanks @jtpio, let's try it.

@brichet brichet closed this Oct 21, 2024
@brichet brichet mentioned this pull request Oct 21, 2024
@brichet
Copy link
Contributor Author

brichet commented Oct 21, 2024

Got something similar recently in jupyter-server/jupyter_releaser#585.

Recreating a new PR (with the same changes) fixed it. Not sure yet of the root cause, but it might be something to investigate if it keeps happening.

So if you close this PR and open a new one, so the PR number changes, maybe it will help.

That was it, thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants