Fix mypy

[brichet]

This PR should fix mypy which fails with the bump_version.py file.

[github-actions]

👈 Launch a Binder on branch brichet/jupyter_collaboration/fix_mypy

[davidbrochart]

I think we should just exclude this file from mypy, it's not typed at all.

[davidbrochart]

Thanks, failures are unrelated, let's fix them in another PR.

[davidbrochart]

Wait, pre-commit is still failing? It means mypy is still analysing this file? Also, we don't need # type: ignore anymore:

from pkg_resources import parse_version  # type: ignore

[brichet]

Wait, pre-commit is still failing? It means mypy is still analysing this file?

Yes, I saw that...

Also, we don't need # type: ignore anymore:

from pkg_resources import parse_version  # type: ignore

The 2 first commits that I reverted fixed mypy for that file.

[brichet]

Thanks @davidbrochart.

Should we remove

    "^binder/jupyter_config\\.py$",
    "^scripts/bump_version\\.py$",
    "/setup\\.py$",
]

from pyproject.toml to avoid confusion, or is this useful for local run ?

[davidbrochart]

Yes I think it's still useful outside of pre-commit.